Pelion-Ready branding review #953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
melwee01 commented Feb 18, 2019
docs/device-management-test.md Outdated
| <h2 id="device-management-test">Validation and testing</h2> | ||
| | ||
| Mbed Device Management provides built-in tests to help you when define your device management configuration. Before running these tests, we recommend you refer to the [testing setup](#testing-setup) section below. | ||
| Device Management provides built-in tests to help you when define your device management configuration. Before running these tests, we recommend you refer to the [testing setup](#testing-setup) section below. |
There was a problem hiding this comment.
Any way to rephrase this so it's not repetitive?
There was a problem hiding this comment.
I think the "help you when define" is the real issue
docs/device-management-test.md Outdated
| 1. Import an example application for Pelion Device Management that contains the corresponding configuration for your target. | ||
| 1. Import an example application for Device Management that contains the corresponding configuration for your target. | ||
| | ||
| Please refer to the following [application example](https://github.com/ARMmbed/pelion-ready-example). It demonstrates how to connect to the Pelion IoT Platform service, register resources and get ready to receive a firmware update. |
There was a problem hiding this comment.
Is this really meant to be a reference to the entire platform? That include services outside Device Management.
There was a problem hiding this comment.
Do you mean the term "Pelion IoT Platform service" includes services outside Device Management, or the example does? If the former, probably not. What should it be instead?
There was a problem hiding this comment.
Pelion IoT Platform includes services outside of Device Management. Does the examples include/use those outside services?
There was a problem hiding this comment.
If not, it should just be Device Management.
| 1. Import an example application for Device Management that contains the corresponding configuration for your target. | ||
| | ||
| Please refer to the following [application example](https://github.com/ARMmbed/pelion-ready-example). It demonstrates how to connect to the Pelion IoT Platform service, register resources and get ready to receive a firmware update. | ||
| |
There was a problem hiding this comment.
Line 64: Same as note above.
docs/device-management.md Outdated
| To help you start quickly, please refer to the following [application example](https://github.com/ARMmbed/pelion-ready-example). It demonstrates how to connect to the Pelion IoT Platform service, register resources and get ready to receive a firmware update. | ||
| Also, there are a number of board-specific applications that focus on providing more elaborate hardware features with Mbed OS and the Pelion IoT Platform. These are available in the Pelion [quick start](https://cloud.mbed.com/quick-start). Please see the reference table below, organized by vendor name, for details: | ||
| Also, there are a number of board-specific applications that focus on providing more elaborate hardware features with Mbed OS and the Pelion IoT Platform. These are available in the Device Management [quick start](https://cloud.mbed.com/quick-start). Please see the reference table below, organized by vendor name, for details: |
There was a problem hiding this comment.
Again on lines 95/97: does this include all of Pelion or just Device Management as a service?
melwee01 commented Feb 18, 2019
docs/device-management-test.md Outdated
| #### Device identity is inconsistent | ||
| If your device ID in Pelion Device Management is inconsistent over a device reset, it could be because it is failing to open the credentials on the storage held in the Enhanced Secure File System. Typically, this is because the device cannot access the Root of Trust stored in SOTP. | ||
| If your device ID in Device Management is inconsistent over a device reset, it could be because it is failing to open the credentials on the storage held in the Enhanced Secure File System. Typically, this is because the device cannot access the Root of Trust stored in SOTP. |
There was a problem hiding this comment.
Maybe "... is inconsistent when your device resets, it ..."?
docs/device-management.md Outdated
| - Provides end-to-end Greentea tests for Device Management. | ||
| | ||
| This library makes it trivial to expose sensors, actuators and other variables to a cloud service. For a complete Pelion Device Management Client API, please see our [documentation](https://cloud.mbed.com/docs/current/mbed-cloud-client/index.html). | ||
| This library makes it trivial to expose sensors, actuators and other variables to a cloud service. For a complete Device Management Client API, please see our [documentation](https://cloud.mbed.com/docs/current/mbed-cloud-client/index.html). <!---This isn't a link to API references, though.---> |
There was a problem hiding this comment.
Could you suggest a link in its place?
There was a problem hiding this comment.
added 4 commits February 19, 2019 16:59
Delete extra word for clarification, as requested in comment.
Fix failing Travis build.
Fix branding, and clarify confusing clause with suggestions in comments.
Update branding and links, as suggested in comments.
AnotherButler pushed a commit that referenced this pull request Feb 25, 2019
Fix spelling and branding by applying PR #953 to development branch.
AnotherButler pushed a commit that referenced this pull request Feb 25, 2019
Fix branding by applying PR #953 to development branch.
AnotherButler pushed a commit that referenced this pull request Feb 25, 2019
Fix branding by applying changes from PR #953 to development branch.
| I've made these changes manually to avoid the merge conflicts, so I'm closing this PR. |
| Sorry, that was my fault |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.