Skip to content

Cellular docs updated #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2019
Merged

Cellular docs updated #914

merged 1 commit into from
Feb 20, 2019

Conversation

@AriParkkila
Copy link

@AriParkkila AriParkkila commented Jan 11, 2019

Cellular docs updated for Mbed OS 5.12.

Porting guide need to be finished later.
melwee01
melwee01 suggested changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@melwee01 melwee01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit too much passive voice for my taste, but I don't know that we can afford to be that picky.
@melwee01 melwee01 added the docathlon2019 doxygen review label Jan 11, 2019
AnotherButler
AnotherButler reviewed Jan 17, 2019
View reviewed changes
Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left some comments asking about links I can't get to work. I think maybe that's on the Doxygen/code end?
@AnotherButler
Copy link
Contributor

AnotherButler commented Jan 18, 2019

@AriParkkila Thanks for clarifying. Because this depends on code that hasn't merged yet, I'm going to add a code dependency label. Could you please link to the relevant mbed-os PR?
@AnotherButler
Copy link
Contributor

AnotherButler commented Feb 8, 2019

@AriParkkila or @mirelachirica Could one of you please let me know which code PR (if there is one) this is waiting for? Also, could you please resolve the merge conflicts?
@AriParkkila
Copy link
Author

AriParkkila commented Feb 11, 2019

@AnotherButler PR has not been made yet. This time we documented it before anything was implemented, so I guess we are learning :) I will rebase and update this when PR is ready.
@AriParkkila
Copy link
Author

AriParkkila commented Feb 18, 2019 •
edited
Loading

@AnotherButler PR for the CellularInterface class ARMmbed/mbed-os#9746

Rebased and ready for merge.
@AnotherButler AnotherButler merged commit f0e9c99 into ARMmbed:development Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docathlon2019 doxygen review

3 participants

@AriParkkila @AnotherButler @melwee01