Skip to content

Create cli_install.md #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2017
Merged

Create cli_install.md #187

merged 3 commits into from
Jun 30, 2017

Conversation

AnotherButler
Copy link
Contributor

  • Move page to Handbook
  • Include copy edits, mostly for active voice, consistent capitalization and inclusion of articles.
Create CLI_install.md
ca4b118 
- Move page from private repo - Include copy edits, mostly for active voice, consistent capitalization and inclusion of articles.
@AnotherButler AnotherButler changed the title Create CLI_install.md Create cli_install.md Jun 29, 2017
AnotherButler pushed a commit that referenced this pull request Jun 29, 2017
Add CLI installer page to YML
2052843 
WAIT UNTIL PR #187 MERGES BEFORE MERGING
@AnotherButler AnotherButler mentioned this pull request Jun 29, 2017
Merged
arekzaluski
arekzaluski requested changes Jun 29, 2017
View reviewed changes
Copy link
Contributor

@arekzaluski arekzaluski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires an update in link from version 0.4.0 to 0.4.1 . I'll update it tomorrow morning so it can be published together with blog post on developer.mbed.org
@arekzaluski
Copy link
Contributor

@AnotherButler Unfortunately I do not have rights to add a commit to this PR. It needs to include the latest changes in https://github.com/ARMmbed/mbed-cli-windows-installer/blob/master/setup.md. The changes can be found here: ARMmbed/mbed-cli-windows-installer@d4b7218
@MarceloSalazar It may be a good idea to name it an alpha version. (It will be the first officially released version). What do you think about it?
@arekzaluski
Copy link
Contributor

@JoeTheGuitarist ^
@JoeTheGuitarist
Copy link
Member

It's not really an alpha - I think just stick with the versioning @arekzaluski has established without a readiness indicator like "alpha".
Update link and version change in cli_install.md
1a90c42 
Update changes from @arekzaluski with version and link
@AnotherButler
Copy link
Contributor Author

@arekzaluski I didn't think there'd be permissions issues. My apologies. I have fixed it now. Thanks for the helpful link. :)

Please let me know whenever this is ready for merging.
@JoeTheGuitarist
Copy link
Member

Ready for merging now as far as I know. Thanks for your help @AnotherButler :)
@AnotherButler AnotherButler merged commit 1e828fb into 5.5 Jun 30, 2017
@AnotherButler AnotherButler deleted the AnotherButler-patch-1 branch June 30, 2017 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@AnotherButler @arekzaluski @JoeTheGuitarist