Skip to content

Conversation

@LDong-Arm
Copy link
Contributor

Fixes #1332

This PR

  • stresses on the serial driver doc page that it only applies to Windows 7
  • update other docs that link to the serial driver doc page
@LDong-Arm
Copy link
Contributor Author

The wording is "Windows 7" rather than "earlier than Windows 8" (which may cause confusion - is it inclusive of 8?) or "Windows 7 or earlier" (I don't think we support Vista, etc.), does it sound okay?

@MarceloSalazar
Copy link
Contributor

I assume we don't want to actively advertise the need of the driver but keep the content as it's searchable. So maybe references from lora, dap and possibly UnbufferedSerial/BufferedSerial could be removed.

Note most mbed-os-example-*** apps use the serial port but we're not advertising the need for the driver (I don't think we should).

@LDong-Arm
Copy link
Contributor Author

@MarceloSalazar Completely agree. I just removed links to the serial driver doc from pages other than intro and serial communication which are directly relevant.

Copy link
Contributor

@MarceloSalazar MarceloSalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

The Arm Mbed microcontroller on your board can communicate with a host PC over the same USB cable that you use for programming.

<span class="tips">If you're working on Windows earlier than Windows 10, you might need to [install a serial driver](../program-setup/windows-serial-driver.html).</span>
<span class="tips">If you're working on Windows 7, you might need to [install a serial driver](../program-setup/windows-serial-driver.html).</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what about Windows 8? Does that work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@thegecko thegecko Jun 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, it shouldn't be used on Windows 8 either

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry by "works" I meant no driver needed

Co-authored-by: Irit Arkin <irit.arkin@arm.com>
@LDong-Arm LDong-Arm requested a review from iriark01 June 2, 2020 15:28
@iriark01 iriark01 merged commit babe282 into development Jun 3, 2020
iriark01 added a commit that referenced this pull request Jun 3, 2020
* That images has been broken for ages * Adding AWS - but not to 6.0 yet because it 404s * A serial driver should be installed on Windows 7 only (#1334) * A serial driver should be installed on Windows 7 only * Remove links to serial driver from feature-related pages * Apply suggestions from code review Co-authored-by: Irit Arkin <irit.arkin@arm.com> Co-authored-by: Irit Arkin <irit.arkin@arm.com> * That doesn't work yet Co-authored-by: Lingkai Dong <lingkai.dong@arm.com>
@iriark01 iriark01 deleted the serial_driver_windows_7 branch June 12, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants