Fixed extraScrollHeight bug with ScrollView #331
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I came across a bug on this library related with setting an extraScrollHeight on the KeyboardAwareView. This changes fix the extra margin that appears after the keyboard disappears on the ScrollView. What would happen is:
This was caused because on _resetKeyboardSpace you were setting
keyboardSpace: number = this.props.viewIsInsideTabBar ? _KAM_DEFAULT_TAB_BAR_HEIGHT + this.props.extraScrollHeight || 0 : this.props.extraScrollHeight || 0
which caused the
keyboardSpace
to beextraScrollHeight
instead of 0 after the keyboard closed.Hope this helps!