Skip to content

Conversation

@iRoachie
Copy link
Contributor

React.createClass is deprecated in react15.5 and throws errors. This PR replaces it with the drop in replacement create-react-class

@iRoachie
Copy link
Contributor Author

Also fixes #140, there was a stray React.PropTypes still remaining.

@cladjules
Copy link

Hi iRoachie, thanks for the fix,

when can we have that in the master?
So we can start using it.

Thanks :)

@iRoachie
Copy link
Contributor Author

Currently waiting on merge. @Swordsman-Inaction

@Swordsman-Inaction Swordsman-Inaction requested review from Swordsman-Inaction and alvaromb and removed request for alvaromb July 20, 2017 15:26
@Swordsman-Inaction Swordsman-Inaction merged commit 79e5fda into APSL:master Jul 20, 2017
@iRoachie iRoachie deleted the create-react-class branch July 20, 2017 18:01
@itsmepetrov
Copy link

itsmepetrov commented Jul 23, 2017

@Swordsman-Inaction please, publish the new version to npm

@Swordsman-Inaction
Copy link
Collaborator

@alvaromb Can you do it?

@itsmepetrov Sorry, I don't have the permission to push a new version. But you can use github:APSL/react-native-keyboard-aware-scroll-view#commit-id to use this commit before it's pushed.

@iRoachie
Copy link
Contributor Author

iRoachie commented Jul 24, 2017

"react-native-keyboard-aware-scroll-view": "https://github.com/APSL/react-native-keyboard-aware-scroll-view.git"

What I'm currently using

@alvaromb
Copy link
Collaborator

Sorry for the delay, I'm publishing it today!

@itsmepetrov
Copy link

@alvaromb any updates?

@isnifer
Copy link

isnifer commented Aug 4, 2017

@alvaromb please update module on npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants