code optimisation for circular references issue #351
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fix: continueOnError behaves correctly when parsing result is empty
… parts add dereferencedCache to avoid to re-treat object already dereferenced
* Custom bundling * Handle some edge cases * Better defaults + typings * Do not lint test fixtures * Improve docs & defaults * Update lib/bundle/util/suggestName.js Co-authored-by: William Hilton <wmhilton@gmail.com> * Update lib/bundle/index.js Co-authored-by: William Hilton <wmhilton@gmail.com> * chore: explain code via comments Co-authored-by: William Hilton <wmhilton@gmail.com>
* Recognize file version * Support SRNs * Handle references that are not moved under custom root * Recognize mid correctly * Broken closest root lookup * Detect v2 references * SRN might be empty
* Include mid only in case of collision * Update lib/bundle/util/key-generator.js
…essage improve MissingPointerError message
chore: increase suggest key attempts
convert relative refs when resolving an external schema
undo toFileSystemPath changes
fix bug in test helper
process refs through fileSystemPath to account for os & browser
add check to not convert actual urls
BREAKING CHANGE: binary parser is no longer bundled
BREAKING CHANGE: fetch & AbortController are not polyfilled anymore
BREAKING CHANGE: introduces package exports
| This branch is completely divergent from HEAD. If you can isolate the changes into a PR that touches just the typescript files and adds tests I would merge that in. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Getting 500 Error or Sometimes might need to wait a long time before getting this error when spec having circular references