fix: change type of onDereference to non-required #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Also @philsturgeon I'm happy to takeover this project. I was meaning to rewrite in typescript one of these days anyways |
| This change looks good to me! |
| @jonluca thank you for the fix and the offer! I’ve added you as a maintainer as well as @jamesmoschou, so the two of you could share responsibilities and review each other’s work. I’ll be around if you need anything, same username on most of the socials. |
Pull Request Test Coverage Report for Build 3972085564
💛 - Coveralls |
philsturgeon approved these changes Jan 23, 2023
| 🎉 This PR is included in version 10.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The type of onDereference is required, which breaks types in some downstream packages. The code also checks for its existence on L72 of dereference.js so this is fine.