feat: add support for options.dereference.onDereference #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tillkolter reviewed Jul 1, 2022
| path.includes("/example/") | ||
| path.includes("/example/"), | ||
| onDereference: (path, value) => // Callback invoked during dereferencing | ||
| console.log(path, value) |
There was a problem hiding this comment.
is this an C&P artifact or intended?
There was a problem hiding this comment.
This is intended. It's the documentation.
| Hi I'm trying to get this merged via a new pull request, and got past the linting issues. Now it's giving me a failed test, could you take a look? |
| Turns out that issue is unrelated to this PR so I've got it merged! Thank you. If you could help fix #283 that would be ideal but either way this change will be out in the next release. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This callback is needed for bcherny/json-schema-to-typescript#453, in order to more intelligently emit TypeScript types from JSON Schemas. Specifically, this change lets us use referenced names for type names, which results in more intuitive and human-readable types. I've implemented it as a generic hook for json-schema-ref-parser.