Fixes treating empty parsing results #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Requesting @P0lip to take a look at this, since he knows that logic best |
P0lip approved these changes Jun 26, 2020
There was a problem hiding this comment.
I've already reviewed the same code in our internal PR here stoplightio#3.
Looks good - AFAIK we've already also had tested it live on a number of models.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes the condition of rejecting empty parsing results.
Currently, when
options.continueOnErroris true and result is empty it will reject.With this change, it will reject only if
allowEmptyis false.I'm a bit unsure whether this should be still dependent on
continueOnError.