Throw errors with more meaningful paths #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Merged
philsturgeon approved these changes May 1, 2020
| @P0lip - It looks like something in this PR doesn't work on Windows. CI is passing on Linux and Mac but failing on Windows https://github.com/APIDevTools/json-schema-ref-parser/actions/runs/93093603 |
| @JamesMessinger I see - going to take a look this weekend. Seems like a path might be incorrect (slashes), but I need to take a look to confirm. |
| Thanks @P0lip ! |
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #164
I felt like a separate test suite was the best choice here, but happy to spread these new tests across some existing ones if you think that'd be a better option.