Fix the Indices of the inpaint filter #461
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Hello. Can you please target this to rolling. Then, we can backport it. Thanks for the submission. |
ipa-dmo force-pushed the fix_inpaint_filter branch from a6a4236 to a63203f Compare Collaborator
| Also, do you have any recommendations on how to write an automated test to verify the fix? |
Collaborator
| Even if not automated, do you have any recommendations on how I can verify this is correct, or reproduce the problem before this patch is applied? I am not yet familiar with this part of the codebase. Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The inpaint filter does not use the correct indices when creating the new grid map layer.
This issue is also included in the iron release.