Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
2bfcee4
fix: check if content is set for rollup properties
johguentner Jul 9, 2022
2507d0f
Apply fixes from StyleCI (#67)
mechelon Jul 9, 2022
7a9da2d
polish/fix: control over 'includeTime' of Date
johguentner Jul 9, 2022
8111720
add: test for edge case of empty Select in Rollup
johguentner Jul 9, 2022
32fbfc6
Apply fixes from StyleCI (#70)
mechelon Jul 9, 2022
0283feb
fix test: breaking-changes in Date prop handling
johguentner Jul 9, 2022
420c037
add tests: for Date Property with forced time
johguentner Jul 9, 2022
85a8ff8
Apply fixes from StyleCI (#71)
mechelon Jul 9, 2022
0fdd0c0
add: better pagination handling
johguentner Jul 10, 2022
5d11817
Apply fixes from StyleCI (#72)
mechelon Jul 10, 2022
dafd6de
polish: handling for empty next_cursor
johguentner Jul 10, 2022
e1b3aca
add tests for improved pagination handling
johguentner Jul 10, 2022
a64227c
Merge branch 'feature/better-pagination-handling' of https://github.c…
johguentner Jul 10, 2022
bc8a3e6
Apply fixes from StyleCI (#74)
mechelon Jul 10, 2022
c541080
polish/fix: read (fetch) hasTime in date property
johguentner Jul 11, 2022
0a07217
modify tests: evaluate 'hasTime' in date props
johguentner Jul 11, 2022
a77289e
clarify: move edge-case label to test method
johguentner Jul 11, 2022
9aa463a
Apply fixes from StyleCI (#75)
mechelon Jul 11, 2022
b935959
Merge pull request #68 from 5am-code/65-rollup-with-empty-select-fix
johguentner Jul 11, 2022
461b1dd
Merge pull request #69 from 5am-code/61-choose-time-format
johguentner Jul 11, 2022
66ca7af
Merge branch 'dev' into feature/better-pagination-handling
johguentner Jul 11, 2022
2451387
Apply fixes from StyleCI (#76)
mechelon Jul 11, 2022
f1e0af9
Merge pull request #73 from 5am-code/feature/better-pagination-handling
johguentner Jul 11, 2022
40ed8ac
fix: check if content is null in date property
johguentner Aug 1, 2022
1963906
Apply fixes from StyleCI (#78)
mechelon Aug 1, 2022
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply fixes from StyleCI (#74)
  • Loading branch information
mechelon authored Jul 10, 2022
commit bc8a3e6cc717a7e2c23319f89e361d773628b90e
5 changes: 4 additions & 1 deletion src/Entities/Collections/EntityCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,10 @@ public function hasMoreEntries(): bool
public function nextCursor(): ?StartCursor
{
$rawNextCursor = $this->getRawNextCursor();
if($rawNextCursor === null) return null;
if ($rawNextCursor === null) {
return null;
}

return new StartCursor($rawNextCursor);
}
}
9 changes: 4 additions & 5 deletions tests/EndpointDatabaseTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -164,18 +164,17 @@ public function it_queries_a_database_with_and_without_offset_and_processes_resu
{
// success /v1/databases/DATABASE_DOES_EXIST/query
Http::fake([
'https://api.notion.com/v1/databases/8284f3ff77e24d4a939d19459e4d6bdc/query*' =>
Http::sequence()
'https://api.notion.com/v1/databases/8284f3ff77e24d4a939d19459e4d6bdc/query*' => Http::sequence()
->push(
json_decode(file_get_contents("tests/stubs/endpoints/databases/response_query_offset_start_200.json"), true),
json_decode(file_get_contents('tests/stubs/endpoints/databases/response_query_offset_start_200.json'), true),
200,
['Headers']
)
->push(
json_decode(file_get_contents("tests/stubs/endpoints/databases/response_query_offset_end_200.json"), true),
json_decode(file_get_contents('tests/stubs/endpoints/databases/response_query_offset_end_200.json'), true),
200,
['Headers']
)
),
]);

$result = Notion::database('8284f3ff77e24d4a939d19459e4d6bdc')
Expand Down