Skip to content

Conversation

@nixel2007
Copy link
Member

@nixel2007 nixel2007 commented Nov 8, 2025

Описание

Связанные задачи

Closes

Чеклист

Общие

  • Ветка PR обновлена из develop
  • Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
  • Изменения покрыты тестами
  • Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Для диагностик

  • Описание диагностики заполнено для обоих языков (присутствуют файлы для обоих языков, для русского заполнено все подробно, перевод на английский можно опустить)

Дополнительно

Summary by CodeRabbit

  • Chores
    • Added error tracking and monitoring configuration
    • Updated build configuration with additional dependency exclusions for language tool packages
    • Updated development environment settings
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 8, 2025

Walkthrough

Configuration and dependency updates across multiple files: .gitignore rule addition for Copilot files, commons-logging exclusions in build dependencies, Java utility method replacement for case-insensitive string comparison, and a new Sentry DSN configuration file.

Changes

Cohort / File(s) Change Summary
Configuration & Ignores
.gitignore
Added ignore pattern /.idea/copilot*.xml for Copilot-generated XML files in .idea directory
Build Dependencies
build.gradle.kts
Added commons-logging exclusion rules to language-en and language-ru dependencies alongside existing JAXB exclusions
Source Code Updates
src/main/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/SourceDefinedMethodCallInlayHintSupplier.java
Replaced StringUtils.containsIgnoreCase() with Strings.CI.contains() for case-insensitive string comparison; updated corresponding import statement
Observability Configuration
src/main/resources/sentry.properties
Added new Sentry configuration file with DSN endpoint for error tracking

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • The changes are predominantly configuration and dependency updates with low complexity
  • Single source code change is a straightforward utility method replacement with equivalent behavior
  • No control flow or logic modifications

Poem

🐰 A rabbit hops through config lands,
Copilot files now neatly fanned,
Dependencies aligned just right,
String checks switching—cleaner sight,
Sentry watches from above so bright! 🌙

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title in Russian translates to 'Fixed excessive output at application startup' and aligns with the changes which add logging/output configuration (sentry.properties DSN) and fix utility usage patterns.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/stdout-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.gitignore (1)

83-83: Note: Unrelated housekeeping change.

While ignoring Copilot-generated IDE files is good practice, this change appears unrelated to the PR's stated objective of fixing excessive startup output. Consider moving housekeeping changes to separate PRs for clearer history.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94fbc58 and a9ed87a.

📒 Files selected for processing (4)
  • .gitignore (1 hunks)
  • build.gradle.kts (1 hunks)
  • src/main/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/SourceDefinedMethodCallInlayHintSupplier.java (2 hunks)
  • src/main/resources/sentry.properties (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-04-18T22:46:43.245Z
Learnt from: nixel2007 Repo: 1c-syntax/bsl-language-server PR: 3449 File: src/main/java/com/github/_1c_syntax/bsl/languageserver/utils/expressiontree/ExpressionTreeBuildingVisitor.java:192-203 Timestamp: 2025-04-18T22:46:43.245Z Learning: В проекте bsl-language-server класс BSLParser.ExpressionContext наследуется от BSLParserRuleContext, а не напрямую от ParserRuleContext. При работе с ним нужно учитывать специфичные методы BSLParserRuleContext. 

Applied to files:

  • src/main/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/SourceDefinedMethodCallInlayHintSupplier.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: Analyse
  • GitHub Check: Benchmark
  • GitHub Check: build (25, windows-latest)
  • GitHub Check: build (17, windows-latest)
  • GitHub Check: build (21, macOS-latest)
  • GitHub Check: build (25, ubuntu-latest)
  • GitHub Check: build (21, ubuntu-latest)
  • GitHub Check: build (21, windows-latest)
  • GitHub Check: build (17, ubuntu-latest)
  • GitHub Check: Analyze the repo with CodeSee
  • GitHub Check: build (25, macOS-latest)
  • GitHub Check: build (17, macOS-latest)
  • GitHub Check: build (17, windows-latest)
  • GitHub Check: build (25, ubuntu-latest)
  • GitHub Check: build (25, windows-latest)
  • GitHub Check: build (21, macOS-latest)
  • GitHub Check: build (21, windows-latest)
  • GitHub Check: build (21, ubuntu-latest)
  • GitHub Check: build (17, ubuntu-latest)
  • GitHub Check: build
🔇 Additional comments (3)
src/main/resources/sentry.properties (1)

1-1: Document the Sentry integration purpose.

The addition of Sentry error tracking is not mentioned in the PR description. While Sentry DSNs are safe to commit publicly, please clarify:

  • How does this relate to fixing excessive startup output?
  • Is this intended to replace or supplement existing error handling?
  • Should this configuration be environment-specific rather than hardcoded?
build.gradle.kts (1)

103-112: LGTM! Consistent logging exclusions reduce startup noise.

Excluding commons-logging from language-en and language-ru dependencies aligns with the existing exclusion for languagetool-core and directly addresses the PR objective of reducing excessive startup output.

src/main/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/SourceDefinedMethodCallInlayHintSupplier.java (1)

36-36: Verification complete—refactoring is correct.

Apache Commons Lang 3.19.0 includes the Strings class with Strings.CI.contains method, and the method performs case‑insensitive contains check with behavior equivalent to StringUtils.containsIgnoreCase. The refactoring maintains the same behavior and is appropriate.

@nixel2007 nixel2007 enabled auto-merge November 8, 2025 06:26
@nixel2007 nixel2007 merged commit dd52c7f into develop Nov 8, 2025
46 checks passed
@nixel2007 nixel2007 deleted the fix/stdout-fixes branch November 8, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants