- Notifications
You must be signed in to change notification settings - Fork 117
Исправлен избыточный выхлоп при старте приложения #3589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughConfiguration and dependency updates across multiple files: .gitignore rule addition for Copilot files, commons-logging exclusions in build dependencies, Java utility method replacement for case-insensitive string comparison, and a new Sentry DSN configuration file. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.gitignore (1)
83-83: Note: Unrelated housekeeping change.While ignoring Copilot-generated IDE files is good practice, this change appears unrelated to the PR's stated objective of fixing excessive startup output. Consider moving housekeeping changes to separate PRs for clearer history.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.gitignore(1 hunks)build.gradle.kts(1 hunks)src/main/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/SourceDefinedMethodCallInlayHintSupplier.java(2 hunks)src/main/resources/sentry.properties(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-04-18T22:46:43.245Z
Learnt from: nixel2007 Repo: 1c-syntax/bsl-language-server PR: 3449 File: src/main/java/com/github/_1c_syntax/bsl/languageserver/utils/expressiontree/ExpressionTreeBuildingVisitor.java:192-203 Timestamp: 2025-04-18T22:46:43.245Z Learning: В проекте bsl-language-server класс BSLParser.ExpressionContext наследуется от BSLParserRuleContext, а не напрямую от ParserRuleContext. При работе с ним нужно учитывать специфичные методы BSLParserRuleContext. Applied to files:
src/main/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/SourceDefinedMethodCallInlayHintSupplier.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: Analyse
- GitHub Check: Benchmark
- GitHub Check: build (25, windows-latest)
- GitHub Check: build (17, windows-latest)
- GitHub Check: build (21, macOS-latest)
- GitHub Check: build (25, ubuntu-latest)
- GitHub Check: build (21, ubuntu-latest)
- GitHub Check: build (21, windows-latest)
- GitHub Check: build (17, ubuntu-latest)
- GitHub Check: Analyze the repo with CodeSee
- GitHub Check: build (25, macOS-latest)
- GitHub Check: build (17, macOS-latest)
- GitHub Check: build (17, windows-latest)
- GitHub Check: build (25, ubuntu-latest)
- GitHub Check: build (25, windows-latest)
- GitHub Check: build (21, macOS-latest)
- GitHub Check: build (21, windows-latest)
- GitHub Check: build (21, ubuntu-latest)
- GitHub Check: build (17, ubuntu-latest)
- GitHub Check: build
🔇 Additional comments (3)
src/main/resources/sentry.properties (1)
1-1: Document the Sentry integration purpose.The addition of Sentry error tracking is not mentioned in the PR description. While Sentry DSNs are safe to commit publicly, please clarify:
- How does this relate to fixing excessive startup output?
- Is this intended to replace or supplement existing error handling?
- Should this configuration be environment-specific rather than hardcoded?
build.gradle.kts (1)
103-112: LGTM! Consistent logging exclusions reduce startup noise.Excluding
commons-loggingfrom language-en and language-ru dependencies aligns with the existing exclusion for languagetool-core and directly addresses the PR objective of reducing excessive startup output.src/main/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/SourceDefinedMethodCallInlayHintSupplier.java (1)
36-36: Verification complete—refactoring is correct.Apache Commons Lang 3.19.0 includes the Strings class with Strings.CI.contains method, and the method performs case‑insensitive contains check with behavior equivalent to StringUtils.containsIgnoreCase. The refactoring maintains the same behavior and is appropriate.
|



Описание
Связанные задачи
Closes
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно
Summary by CodeRabbit