Новая диагностика - Серверный экспортный метод формы #1849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
asosnoviy reviewed Oct 4, 2021
.../_1c_syntax/bsl/languageserver/diagnostics/IncorrectExportFormMethodDiagnostic_ru.properties Outdated Show resolved Hide resolved
nixel2007 reviewed Oct 5, 2021
nixel2007 reviewed Oct 5, 2021
nixel2007 reviewed Oct 5, 2021
...m/github/_1c_syntax/bsl/languageserver/diagnostics/ServerSideExportFormMethodDiagnostic.java Outdated Show resolved Hide resolved
nixel2007 reviewed Oct 5, 2021
...m/github/_1c_syntax/bsl/languageserver/diagnostics/ServerSideExportFormMethodDiagnostic.java Outdated Show resolved Hide resolved
nixel2007 reviewed Oct 5, 2021
...m/github/_1c_syntax/bsl/languageserver/diagnostics/ServerSideExportFormMethodDiagnostic.java Outdated Show resolved Hide resolved
theshadowco force-pushed the feature/ExportMethodInForm branch 2 times, most recently from 58ba4f6 to cda7d7d Compare nixel2007 reviewed Oct 5, 2021
src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/DiagnosticStorage.java Outdated Show resolved Hide resolved
asosnoviy changed the title nixel2007 reviewed Oct 6, 2021
src/main/java/com/github/_1c_syntax/bsl/languageserver/diagnostics/DiagnosticStorage.java Outdated Show resolved Hide resolved
nixel2007 reviewed Oct 6, 2021
src/main/java/com/github/_1c_syntax/bsl/languageserver/context/symbol/ModuleSymbol.java Outdated Show resolved Hide resolved
nixel2007 approved these changes Oct 6, 2021
Member
nixel2007 left a comment
nixel2007 left a comment There was a problem hiding this comment.
небольшой вопрос по поводу ModuleSymbol, а так аппрув
2. Внесены правки в документацию по коду
2. дополнил `ModuleSymbol` областью на первый токен 3. скорректировал метод `addDiagnostic` для работы со всеми символами
theshadowco force-pushed the feature/ExportMethodInForm branch from 56a0e58 to 601d36e Compare 
| Kudos, SonarCloud Quality Gate passed! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Описание
addDiagnosticдляMethodSymbolСвязанные задачи
Closes: #1289
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно