fix(template): use path.Join and rename parameter to fix embed path on Windows #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where templates embedded with //go:embed couldn't be opened on Windows because paths were constructed with filepath.Join which produces backslashes (e.g.
block\letsencrypt.conf). embed.FS expects forward slashes.Changes
path->dirin:GetTemplateInfoParseTemplatepath.Join(dir, name)instead offilepath.Join(...)import "path/filepath"withimport "path"where appropriate.Why
embed.FSnormalizes file names with forward slashes (/). On Windowsfilepath.Joinproduces backslashes which lead to "file does not exist" errors at runtime.path.Joinworks on Linux/macOS and Windows for embedded resources.