Skip to content

Conversation

@boddumanohar
Copy link
Contributor

Changes

Fixes #942

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...
@boddumanohar boddumanohar requested a review from dabasov February 26, 2023 22:31
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Merging #953 (c53ca58) into staging (928d77d) will increase coverage by 0.19%.
The diff coverage is 50.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@ Coverage Diff @@ ## staging #953 +/- ## =========================================== + Coverage 26.38% 26.58% +0.19%  =========================================== Files 76 76 Lines 7663 7707 +44 =========================================== + Hits 2022 2049 +27  - Misses 5375 5390 +15  - Partials 266 268 +2 
Flag Coverage Δ
Unit-Tests 26.58% <50.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/go/0chain.net/blobbercore/reference/shareinfo.go 0.00% <0.00%> (ø)
code/go/0chain.net/blobbercore/handler/handler.go 62.50% <59.45%> (-0.22%) ⬇️
code/go/0chain.net/core/lock/lock.go 100.00% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped true
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber list-share
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging
@dabasov dabasov merged commit 66dd5eb into staging Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants