Skip to content

Conversation

@Hitenjain14
Copy link
Contributor

Changes

Added common method for both validator and blobber to send health check transaction.
Added healthcheck frequency to config/0chain_validator
Created new method type for VALIDATOR_HEALTH_CHECK in blobbercore/transaction/entity

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Merging #951 (207874e) into staging (ccd9e2f) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@ Coverage Diff @@ ## staging #951 +/- ## =========================================== - Coverage 26.53% 26.44% -0.10%  =========================================== Files 76 76 Lines 7638 7665 +27 =========================================== Hits 2027 2027 - Misses 5345 5372 +27  Partials 266 266 
Flag Coverage Δ
Unit-Tests 26.44% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
code/go/0chain.net/blobbercore/handler/health.go 0.00% <0.00%> (ø)
code/go/0chain.net/blobbercore/handler/protocol.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

func ValidatorHealthCheck() (*transaction.Transaction, error) {

if valConfig.Configuration.Capacity == 0 {
// setValidatorHealthCheckError(ErrValidatorHasRemoved)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove dead code

@Hitenjain14 Hitenjain14 self-assigned this Feb 20, 2023
Copy link
Contributor

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we will need to wait for the validator_health_check SC implemented on 0chain, before merging this one.

@Hitenjain14
Copy link
Contributor Author

LGTM, but we will need to wait for the validator_health_check SC implemented on 0chain, before merging this one.

I have been working on it , just wanted to know if we can emit validator health check in DbHealthCheck or new table has to be created.

Copy link
Contributor

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped TRUE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber validator-health
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging
@peterlimg peterlimg merged commit 239d7d1 into staging Feb 25, 2023
@peterlimg peterlimg deleted the validator-health branch February 25, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants