Skip to content

Conversation

@shahnawaz-creator
Copy link
Contributor

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...
@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2023

Codecov Report

Merging #902 (fb1a3c0) into staging (924703b) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@ Coverage Diff @@ ## staging #902 +/- ## =========================================== - Coverage 26.41% 26.34% -0.07%  =========================================== Files 77 77 Lines 7883 7883 =========================================== - Hits 2082 2077 -5  - Misses 5529 5534 +5  Partials 272 272 
Flag Coverage Δ
Unit-Tests 26.34% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
code/go/0chain.net/core/lock/lock.go 87.50% <0.00%> (-12.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterlimg peterlimg dismissed boddumanohar’s stale review January 13, 2023 02:11

We will fix in a new PR

@Manali-Jain-squareops Manali-Jain-squareops merged commit ab4bb70 into staging Jan 13, 2023
@Manali-Jain-squareops Manali-Jain-squareops deleted the fix/folder-mounting-mnt branch January 13, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

10 participants