Skip to content

Conversation

@lpoli
Copy link
Contributor

@lpoli lpoli commented Nov 1, 2022

Changes

This PR had made move operation atomic. Previously it would be copy + delete in which client was charged for copy operation.

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@lpoli lpoli mentioned this pull request Nov 1, 2022
3 tasks
@lpoli lpoli linked an issue Nov 1, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Merging #866 (08b72ba) into staging (d5638af) will increase coverage by 0.72%.
The diff coverage is 28.23%.

@@ Coverage Diff @@ ## staging #866 +/- ## =========================================== + Coverage 25.57% 26.29% +0.72%  =========================================== Files 77 77 Lines 7856 7879 +23 =========================================== + Hits 2009 2072 +63  + Misses 5584 5535 -49  - Partials 263 272 +9 
Flag Coverage Δ
Unit-Tests 26.29% <28.23%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain.net/blobbercore/allocation/allocationchange.go 0.00% <0.00%> (ø)
...o/0chain.net/blobbercore/filestore/file_manager.go 5.26% <ø> (+0.50%) ⬆️
.../go/0chain.net/blobbercore/filestore/mock_store.go 0.00% <ø> (ø)
code/go/0chain.net/blobbercore/filestore/state.go 70.28% <ø> (-0.22%) ⬇️
code/go/0chain.net/blobbercore/filestore/store.go 0.00% <ø> (ø)
...ain.net/blobbercore/handler/file_command_update.go 0.00% <0.00%> (ø)
...et/blobbercore/handler/object_operation_handler.go 31.29% <0.00%> (-3.90%) ⬇️
.../0chain.net/blobbercore/handler/storage_handler.go 22.75% <0.00%> (+0.19%) ⬆️
code/go/0chain.net/blobbercore/handler/worker.go 0.00% <ø> (ø)
code/go/0chain.net/blobbercore/reference/ref.go 0.00% <ø> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk atomic/move
zboxcli staging
zwalletcli staging
0chain staging
blobber atomic/move
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging
@lpoli lpoli marked this pull request as ready for review November 3, 2022 16:51
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk atomic/move
zboxcli atomic/move
zwalletcli staging
0chain staging
blobber atomic/move
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging
Copy link
Contributor

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk atomic/move
zboxcli staging
zwalletcli staging
0chain staging
blobber atomic/move
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging
@lpoli lpoli merged commit ee90839 into staging Nov 4, 2022
@Kishan-Dhakan Kishan-Dhakan deleted the atomic/move branch November 24, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants