fix(logging): improved error logging for zcn query #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## staging #762 +/- ## ======================================== Coverage 23.59% 23.59% ======================================== Files 77 77 Lines 7980 7980 ======================================== Hits 1883 1883 Misses 5828 5828 Partials 269 269
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
peterlimg suggested changes Jul 27, 2022
| d.UseNumber() | ||
| if err := d.Decode(&blobberChallenges); err != nil { | ||
| logging.Logger.Error("[challenge]json: ", zap.Error(err)) | ||
| logging.Logger.Error("[challenge]json: ", zap.String("resp", string(retBytes))) |
There was a problem hiding this comment.
Please log the err too in case
| b := &zcncore.Blobber{} | ||
| if err := json.Unmarshal([]byte(info), b); err != nil { | ||
| cb.Error = err | ||
| cb.Error = fmt.Errorf("getBlobber:json %s", info) |
There was a problem hiding this comment.
include the err err as well
Kishan-Dhakan approved these changes Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):