Modify/datetime #748
Merged
Modify/datetime #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…bber into fix/update-attributes
Remove deleted_at column Update tests Optimize *change.go files
Codecov Report
@@ Coverage Diff @@ ## staging #748 +/- ## =========================================== + Coverage 23.59% 24.37% +0.78% =========================================== Files 77 77 Lines 7980 7818 -162 =========================================== + Hits 1883 1906 +23 + Misses 5828 5646 -182 + Partials 269 266 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
| Manual system tests [success] with the following config
|
peterlimg suggested changes Jul 22, 2022
| func (r *Ref) CalculateDirHash(ctx context.Context, saveToDB bool) (h string, err error) { | ||
| defer func() { | ||
| if err == nil && saveToDB { | ||
| err = r.SaveDirRef(ctx) |
There was a problem hiding this comment.
This defer actions would call the r.SaveDirRef when there's no child.
`autoIncrement` was supposed to work for it fail for sqlite used for integration testing
| Manual system tests [success] with the following config
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):