Update provider enum to start from 1 #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
3 tasks
peterlimg force-pushed the fix/getUsersPool branch from a651855 to ba8b176 Compare 
Codecov Report
@@ Coverage Diff @@ ## staging #733 +/- ## =========================================== + Coverage 24.13% 24.19% +0.06% =========================================== Files 69 69 Lines 7898 7898 =========================================== + Hits 1906 1911 +5 + Misses 5708 5703 -5 Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
peterlimg force-pushed the fix/getUsersPool branch from ba8b176 to a14ce69 Compare 
| Manual system tests [success] with the following config
|
| Manual system tests [success] with the following config
|
| Manual system tests [failure] with the following config
|
peterlimg force-pushed the fix/getUsersPool branch from 373fc13 to b8d5e21 Compare | Manual system tests [failure] with the following config
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes
/getUserPoolsendpoint 0chain#1381Tests
Tasks to complete before merging PR: