Skip to content

Conversation

@ssardana08
Copy link
Contributor

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...
@codecov-commenter
Copy link

Codecov Report

Merging #731 (3e7b7ee) into staging (a2eaa88) will not change coverage.
The diff coverage is 0.00%.

@@ Coverage Diff @@ ## staging #731 +/- ## ======================================== Coverage 24.19% 24.19% ======================================== Files 69 69 Lines 7898 7898 ======================================== Hits 1911 1911 Misses 5703 5703 Partials 284 284 
Flag Coverage Δ
Unit-Tests 24.19% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ode/go/0chain.net/blobbercore/allocation/entity.go 0.00% <ø> (ø)
code/go/0chain.net/blobbercore/handler/protocol.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2eaa88...3e7b7ee. Read the comment docs.

Copy link
Contributor

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ssardana08 ssardana08 merged commit 7440aa2 into staging Jun 18, 2022
@ssardana08 ssardana08 deleted the fix/price_uint64 branch June 18, 2022 11:32
peterlimg pushed a commit that referenced this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants