Remove user write pools #725

Sriep · 2022-06-13T13:58:13Z

Changes

Changes to support single write pool.
Some syntax fixes for currency changes (int64 -> uint64)

Fixes

Tests

Tasks to complete before merging PR:

Ensure system tests are passing. If not Run them manually to check for any regressions 📋
Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

0chain:Write pools 0chain#1465
gosdk:Remove user write pools gosdk#490
system_test: Remove/writepool system_test#315
zboxcli:Remove user write pool zboxcli#258
zwalletcli:
Other: ...

# Conflicts: # go.mod # go.sum

codecov-commenter · 2022-06-17T08:19:53Z

Codecov Report

Merging #725 (667512b) into staging (42f8c3c) will increase coverage by 0.04%.
The diff coverage is 9.67%.

@@ Coverage Diff @@ ## staging #725 +/- ## =========================================== + Coverage 29.26% 29.31% +0.04%  =========================================== Files 77 77 Lines 8002 7980 -22 =========================================== - Hits 2342 2339 -3  + Misses 5316 5297 -19  Partials 344 344

Flag	Coverage Δ
Unit-Tests	`29.31% <9.67%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ode/go/0chain.net/blobbercore/allocation/entity.go	`0.00% <0.00%> (ø)`
...e/go/0chain.net/blobbercore/allocation/protocol.go	`0.00% <0.00%> (ø)`
...et/blobbercore/handler/object_operation_handler.go	`43.03% <42.85%> (+<0.01%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

# Conflicts: # go.mod # go.sum

service-0chain · 2022-06-22T13:31:15Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	remove_write_pools
zboxcli	remove_write_pools
zwalletcli	staging
0chain	remove_write_pools
blobber	remove_write_pools
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

service-0chain · 2022-06-22T17:32:23Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	remove_write_pools
zboxcli	remove_write_pool
zwalletcli	staging
0chain	remove_write_pools
blobber	remove_write_pools
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

service-0chain · 2022-06-27T21:39:38Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	remove/writepool
gosdk	remove_write_pools
zboxcli	remove_write_pool
zwalletcli	staging
0chain	remove_write_pools
blobber	remove_write_pools
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

service-0chain · 2022-07-05T12:09:03Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	remove/writepool
gosdk	remove_write_pools
zboxcli	remove_write_pool
zwalletcli	staging
0chain	write_pools
blobber	remove_write_pools
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

service-0chain · 2022-07-07T12:35:12Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	remove/writepool
gosdk	remove_write_pools
zboxcli	staging
zwalletcli	staging
0chain	write_pools
blobber	remove_write_pools
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

service-0chain · 2022-07-07T19:14:33Z

Manual system tests [success] with the following config

config	value
tests skipped	FALSE
system-tests	remove/writepool
gosdk	remove_write_pools
zboxcli	remove_write_pool
zwalletcli	staging
0chain	write_pools
blobber	remove_write_pools
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

peterlimg

Please fix the lint errors, thanks.

code/go/0chain.net/core/transaction/entity.go

code/go/0chain.net/blobbercore/allocation/protocol.go

service-0chain · 2022-07-12T13:37:26Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	remove/writepool
gosdk	remove_write_pools
zboxcli	remove_write_pool
zwalletcli	staging
0chain	remove_write_pool
blobber	remove_write_pools
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

# Conflicts: # go.mod # go.sum

…write_pools

service-0chain · 2022-07-12T16:18:34Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	remove_write_pools
zboxcli	remove_write_pool
zwalletcli	staging
0chain	write_pools
blobber	remove_write_pools
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

peterlimg

lgtm, please fix the conflicts and system tests

# Conflicts: # go.sum

service-0chain · 2022-07-25T10:01:37Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	NOT OVERRIDDEN
zboxcli	staging
zwalletcli	staging
0chain	staging
blobber	remove_write_pools
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2022-07-26T17:06:09Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	remove/writepool
gosdk	NOT OVERRIDDEN
zboxcli	remove_write_pool
zwalletcli	staging
0chain	write_pools
blobber	remove_write_pools
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2022-07-26T18:44:12Z

Manual system tests [success] with the following config

config	value
tests skipped	FALSE
system-tests	remove/writepool
gosdk	NOT OVERRIDDEN
zboxcli	remove_write_pool
zwalletcli	staging
0chain	write_pools
blobber	remove_write_pools
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2022-07-26T21:15:38Z

Manual system tests [success] with the following config

config	value
tests skipped	TRUE
system-tests	master
gosdk	NOT OVERRIDDEN
zboxcli	staging
zwalletcli	staging
0chain	staging
blobber	remove_write_pools
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

cnlangzi and others added 3 commits June 13, 2022 14:01

fix(zcncore): set nonce on submitting

97d8215

Merge branch 'staging' of https://github.com/0chain/blobber into staging

4ebb65f

remove debug logging

8a4490a

This was referenced Jun 13, 2022

Remove user write pool 0chain/zboxcli#258

Merged

Remove user write pools 0chain/gosdk#490

Merged

Remove write pools and blobber pools 0chain/0chain#1373

Closed

Sriep marked this pull request as draft June 13, 2022 14:02

Merge remote-tracking branch 'origin/staging' into remove_write_pools

bba039d

# Conflicts: # go.mod # go.sum

Sriep added 3 commits June 17, 2022 09:49

merge

9fa047e

fix

2401471

Merge remote-tracking branch 'origin/staging' into remove_write_pools

3d17592

# Conflicts: # go.mod # go.sum

Sriep marked this pull request as ready for review June 20, 2022 16:36

Kishan-Dhakan and others added 2 commits June 23, 2022 22:41

Merge branch 'staging' into remove_write_pools

cf96aec

Merge branch 'staging' into remove_write_pools

e44ee1a

Kishan-Dhakan mentioned this pull request Jun 27, 2022

Remove/writepool 0chain/system_test#315

Merged

Sriep added 4 commits July 2, 2022 15:12

Merge remote-tracking branch 'origin/staging' into remove_write_pools

1c6615c

go mod update

6344658

Merge remote-tracking branch 'origin/staging' into remove_write_pools

fb3490b

go mod

d6aa7d8

Sriep mentioned this pull request Jul 5, 2022

Write pools 0chain/0chain#1465

Merged

3 tasks

Merge branch 'staging' into remove_write_pools

fdcd5af

peterlimg suggested changes Jul 12, 2022

View reviewed changes

code/go/0chain.net/core/transaction/entity.go Outdated Show resolved Hide resolved

code/go/0chain.net/blobbercore/allocation/protocol.go Outdated Show resolved Hide resolved

Sriep added 4 commits July 12, 2022 14:48

Merge remote-tracking branch 'origin/staging' into remove_write_pools

c9e2933

# Conflicts: # go.mod # go.sum

Merge remote-tracking branch 'origin/remove_write_pools' into remove_…

be3544d

…write_pools

gomod + lint review

cb7c507

-> uint64

6fbf14b

Sriep added 2 commits July 20, 2022 14:38

Merge remote-tracking branch 'origin/staging' into remove_write_pools

71b562a

update gomod

f2bd5a5

peterlimg approved these changes Jul 22, 2022

View reviewed changes

Sriep added 5 commits July 22, 2022 10:58

Merge remote-tracking branch 'origin/staging' into remove_write_pools

6427967

# Conflicts: # go.sum

gomod update

02c315e

gomod update

17ae029

gomod update

9b11ad7

Merge remote-tracking branch 'origin/staging' into remove_write_pools

a6085b3

Merge branch 'staging' into remove_write_pools

667512b

dabasov merged commit 85fe9b9 into staging Jul 26, 2022

Kishan-Dhakan deleted the remove_write_pools branch October 22, 2022 12:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove user write pools #725

Remove user write pools #725

Uh oh!

Sriep commented Jun 13, 2022 •

edited

Loading

codecov-commenter commented Jun 17, 2022 •

edited

Loading

service-0chain commented Jun 22, 2022

service-0chain commented Jun 22, 2022

service-0chain commented Jun 27, 2022

service-0chain commented Jul 5, 2022

service-0chain commented Jul 7, 2022

service-0chain commented Jul 7, 2022

peterlimg left a comment

Uh oh!

Uh oh!

service-0chain commented Jul 12, 2022

service-0chain commented Jul 12, 2022

peterlimg left a comment

service-0chain commented Jul 25, 2022

service-0chain commented Jul 26, 2022

service-0chain commented Jul 26, 2022

service-0chain commented Jul 26, 2022

Labels

8 participants

Remove user write pools #725

Remove user write pools #725

Uh oh!

Conversation

Sriep commented Jun 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Fixes

Tests

Associated PRs (Link as appropriate):

codecov-commenter commented Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

service-0chain commented Jun 22, 2022

service-0chain commented Jun 22, 2022

service-0chain commented Jun 27, 2022

service-0chain commented Jul 5, 2022

service-0chain commented Jul 7, 2022

service-0chain commented Jul 7, 2022

peterlimg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

service-0chain commented Jul 12, 2022

service-0chain commented Jul 12, 2022

peterlimg left a comment

Choose a reason for hiding this comment

service-0chain commented Jul 25, 2022

service-0chain commented Jul 26, 2022

service-0chain commented Jul 26, 2022

service-0chain commented Jul 26, 2022

Labels

8 participants

Sriep commented Jun 13, 2022 •

edited

Loading

codecov-commenter commented Jun 17, 2022 •

edited

Loading