Fix/heathcheck #718
Merged
Fix/heathcheck #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## staging #718 +/- ## =========================================== + Coverage 24.06% 24.18% +0.11% =========================================== Files 69 69 Lines 7957 7907 -50 =========================================== - Hits 1915 1912 -3 + Misses 5757 5710 -47 Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dabasov suggested changes Jun 8, 2022
code/go/0chain.net/blobber/worker.go Outdated
| logging.Logger.Warn("failed to refresh blobber BaseURL on chain", zap.Error(err)) | ||
| } | ||
| } | ||
| } else { |
There was a problem hiding this comment.
it's better to avoid if-then-else and replace themwith if-not-then
it's easy to read something like
if err != nil { //some code return } //other codethen
if err == nil { //some code } else { //other code } Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Changes
Fixes
HealthChecksc seems be broken #708: send healtcheck in backgroundTests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):