Skip to content

Conversation

@cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Jun 1, 2022

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • .
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #707 (cfd2342) into staging (77a2091) will increase coverage by 0.06%.
The diff coverage is 0.00%.

@@ Coverage Diff @@ ## staging #707 +/- ## =========================================== + Coverage 24.00% 24.07% +0.06%  =========================================== Files 69 69 Lines 7976 7953 -23 =========================================== Hits 1915 1915 + Misses 5776 5753 -23  Partials 285 285 
Flag Coverage Δ
Unit-Tests 24.07% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/go/0chain.net/blobbercore/allocation/workers.go 0.00% <0.00%> (ø)
code/go/0chain.net/blobbercore/handler/protocol.go 0.00% <0.00%> (ø)
.../go/0chain.net/blobbercore/writemarker/protocol.go 0.00% <0.00%> (ø)
...de/go/0chain.net/blobbercore/writemarker/worker.go 0.00% <0.00%> (ø)
...de/go/0chain.net/validatorcore/storage/protocol.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a2091...cfd2342. Read the comment docs.

@cnlangzi cnlangzi requested a review from peterlimg June 1, 2022 08:32
@cnlangzi cnlangzi marked this pull request as draft June 1, 2022 08:41
@cnlangzi cnlangzi removed the request for review from peterlimg June 1, 2022 09:01
@cnlangzi cnlangzi marked this pull request as ready for review June 1, 2022 09:28
@cnlangzi cnlangzi requested a review from peterlimg June 1, 2022 09:31
Copy link
Contributor

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cnlangzi cnlangzi merged commit 8f09d3e into staging Jun 1, 2022
@cnlangzi cnlangzi deleted the fix/json_bug_on_sc_input branch June 1, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants