Skip to content

Conversation

@cnlangzi
Copy link
Contributor

Changes

Fixes

  • fixed token issue on gosdk.yml

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...
@cnlangzi cnlangzi requested a review from Kishan-Dhakan April 27, 2022 00:13
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #662 (d7f7710) into staging (5dc10b4) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@ ## staging #662 +/- ## ======================================== Coverage 19.79% 19.79% ======================================== Files 66 66 Lines 7482 7482 ======================================== Hits 1481 1481 Misses 5774 5774 Partials 227 227 
Flag Coverage Δ
Unit-Tests 19.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dc10b4...d7f7710. Read the comment docs.

Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit 4f9f332 into staging Apr 27, 2022
@cnlangzi cnlangzi deleted the fix/workflow_gosdk branch April 27, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants