Skip to content

Conversation

@Hitenjain14
Copy link
Contributor

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4d4a6e) 23.64% compared to head (2b0fbdd) 23.64%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@ ## staging #1358 +/- ## ======================================== Coverage 23.64% 23.64% ======================================== Files 87 87 Lines 10099 10099 ======================================== Hits 2388 2388 Misses 7415 7415 Partials 296 296 
Flag Coverage Δ
Unit-Tests 23.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 2206115 into staging Dec 24, 2023
@dabasov dabasov deleted the hotfix/conn-id-index branch December 24, 2023 10:40
dabasov pushed a commit that referenced this pull request Jan 4, 2024
* check prev root and add constraint (#1356) * Hotfix update allocation worker * Fix lint * Fix * Fixed updateAllocationInDB check as well * check prev root and add constraint * check if alloc is updated * rmv check --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> * add index for connection id (#1358) * get round on start * fix hook --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in>
dabasov pushed a commit that referenced this pull request Jan 8, 2024
* Fix get round (#1361) * check prev root and add constraint (#1356) * Hotfix update allocation worker * Fix lint * Fix * Fixed updateAllocationInDB check as well * check prev root and add constraint * check if alloc is updated * rmv check --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> * add index for connection id (#1358) * get round on start * fix hook --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> * fix alloc lock for commit * cleanup --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in>
dabasov pushed a commit that referenced this pull request Jan 21, 2024
* check prev root and add constraint (#1356) * Hotfix update allocation worker * Fix lint * Fix * Fixed updateAllocationInDB check as well * check prev root and add constraint * check if alloc is updated * rmv check --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> * add index for connection id (#1358) * Fix chall cancel commit (#1359) * fix challenge cancel commit * change conn lifetime * Fixed updateAllocationInDB check as well (#1357) * fix alloc lock for commit (#1363) * Fix get round (#1361) * check prev root and add constraint (#1356) * Hotfix update allocation worker * Fix lint * Fix * Fixed updateAllocationInDB check as well * check prev root and add constraint * check if alloc is updated * rmv check --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> * add index for connection id (#1358) * get round on start * fix hook --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> * fix alloc lock for commit * cleanup --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> * fix max objects in dir * fix ut * fix commit lock (#1365) --------- Co-authored-by: Jayash Satolia <jayash.satolia.min19@iitbhu.ac.in> Co-authored-by: Jayash Satolia <73050737+Jayashsatolia403@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants