fix(vue2-jest): interop custom transformer require #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
interop custom transformer require. Some transformers may not interop correctly when requiring, return `transformer.default` or `transformer`. fixes vuejs#383
| Any chance of a test for this? Or maybe someone else can pick it up? |
| @lmiller1990 sorry not had a chance to pick up yet. I'll be picking up shortly |
nogic1008 approved these changes Nov 15, 2021
leonardobenedet approved these changes Sep 19, 2022
| I wonder if we still need this? Is this still an issue on Jest 29 + Vue 2 + vue/vue2-jest@29? |
| @lmiller1990 i'll mark the PR as draft. It may not be needed but yet to upgrade jest to that version. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
interop custom transformer require. Some transformers may not interop correctly when requiring, return
transformer.defaultortransformer.@vue/vue3-jest fix: #391
fixes #383