Skip to content

fix(cli-service): process the webpack failed hook in the serve command #5542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix(cli-service): process the webpack failed hook in the serve command #5542

merged 1 commit into from
Jun 2, 2020

Conversation

@jeneser
Copy link
Contributor

@jeneser jeneser commented Jun 1, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

#4891

Vue CLI forgot to process the webpack failed hook in the serve command.
haoqunjiang
haoqunjiang approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!
@haoqunjiang haoqunjiang merged commit 36f961e into vuejs:dev Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix

2 participants

@jeneser @haoqunjiang