Support empty attributes in TagWriter #910
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Support for empty HTML attributes (like "required", "ng-disabled"...) If you want to use this tool for a custom tag in a project that is mainly Angular-oriented, you may want to write attributes without values. And since members are private, you cannot extend TagWriter (another proposal could be "protecting" fields).
spring-projects-issues added the status: waiting-for-triage 
| @djechelon Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
| @djechelon Thank you for signing the Contributor License Agreement! |
rstoyanchev added the in: web rstoyanchev added type: enhancement rstoyanchev changed the title rstoyanchev pushed a commit that referenced this pull request Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Support for empty HTML attributes (like "required", "ng-disabled"...)
If you want to use this tool for a custom tag in a project that is mainly Angular-oriented, you may want to write attributes without values.
And since members are private, you cannot extend TagWriter (another proposal could be "protecting" fields).