Skip to content

Missing nullability declarations for package web.socket.server.jetty #24745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhoeller merged 1 commit into from
Mar 23, 2020
Merged

Missing nullability declarations for package web.socket.server.jetty #24745

jhoeller merged 1 commit into from
Mar 23, 2020

Conversation

@chenqimiao
Copy link
Contributor

@chenqimiao chenqimiao commented Mar 20, 2020 •
edited
Loading

Introduce @NonNullApi,@NonNullFields to package-info to help tools understand something about nullability.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 20, 2020
@chenqimiao chenqimiao force-pushed the package-with-NonNull branch from 618cf78 to 69c3b2c Compare March 20, 2020 15:11
@jhoeller jhoeller self-assigned this Mar 20, 2020
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 20, 2020
@jhoeller jhoeller added this to the 5.2.5 milestone Mar 20, 2020
@jhoeller jhoeller changed the title Introduce NonNull to package-info Add missing nullability declarations for package web.socket.server.jetty Mar 20, 2020
@jhoeller jhoeller changed the title Add missing nullability declarations for package web.socket.server.jetty Missing nullability declarations for package web.socket.server.jetty Mar 20, 2020
@jhoeller jhoeller added type: bug A general bug for: backport-to-5.1.x and removed type: enhancement A general enhancement labels Mar 20, 2020
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Mar 20, 2020
@spring-projects-issues spring-projects-issues mentioned this pull request Mar 20, 2020
Closed
@spring-projects-issues spring-projects-issues mentioned this pull request Mar 20, 2020
Closed
@jhoeller jhoeller merged commit 0e5f27c into spring-projects:master Mar 23, 2020
jhoeller added a commit that referenced this pull request Mar 23, 2020
@jhoeller
Thread-safe access to WebSocketServerFactory and WebSocketExtensions
fd1ca46 
See gh-24745
jhoeller added a commit that referenced this pull request Mar 24, 2020
@jhoeller
Thread-safe access to WebSocketServerFactory and WebSocketExtensions
dbb0933 
Closes gh-24745
jhoeller added a commit that referenced this pull request Mar 24, 2020
@jhoeller
Thread-safe access to WebSocketServerFactory and WebSocketExtensions
f20027f 
Closes gh-24745
@chenqimiao chenqimiao deleted the package-with-NonNull branch March 25, 2020 03:01
zx20110729 pushed a commit to zx20110729/spring-framework that referenced this pull request Feb 18, 2022
@jhoeller
Thread-safe access to WebSocketServerFactory and WebSocketExtensions
bc83bfb 
Closes spring-projectsgh-24745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: bug A general bug

3 participants

@chenqimiao @jhoeller @spring-projects-issues