Skip to content

Simplify AdvisedSupport.removeAdvisor() #24205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2019
Merged

Simplify AdvisedSupport.removeAdvisor() #24205

merged 1 commit into from
Dec 13, 2019

Conversation

@stsypanov
Copy link
Contributor

@stsypanov stsypanov commented Dec 13, 2019

  1. it's not necessary to call IntroductionAdvisor.getInterfaces() twice for each iteration
  2. instead of calling ArrayList.get() and then ArrayList.remove() we can once call ArrayList.remove() to get and remove item by its index
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 13, 2019
@sbrannen sbrannen self-assigned this Dec 13, 2019
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 13, 2019
@sbrannen sbrannen added this to the 5.2.3 milestone Dec 13, 2019
@sbrannen sbrannen merged commit d9cae33 into spring-projects:master Dec 13, 2019
@sbrannen
Copy link
Member

sbrannen commented Dec 13, 2019

This has been merged into master.

Thanks
sbrannen added a commit that referenced this pull request Dec 13, 2019
@sbrannen
Polish contribution
6fdf5ef 
See gh-24205
@stsypanov stsypanov deleted the simpl branch December 16, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement

3 participants

@stsypanov @sbrannen @spring-projects-issues