Skip to content

Hoist constant result of SerializableTypeWrapper.unwrap() out of loop #24167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2019
Merged

Hoist constant result of SerializableTypeWrapper.unwrap() out of loop #24167

merged 1 commit into from
Dec 9, 2019

Conversation

@stsypanov
Copy link
Contributor

@stsypanov stsypanov commented Dec 9, 2019

There is no point in calculatation of expression

TypeVariable<?> v2 = SerializableTypeWrapper.unwrap(variable);

at each iteration of the loop as far as its result depends only on method's argument.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 9, 2019
@jhoeller jhoeller self-assigned this Dec 9, 2019
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 9, 2019
@jhoeller jhoeller added this to the 5.2.3 milestone Dec 9, 2019
@jhoeller jhoeller merged commit ebbb562 into spring-projects:master Dec 9, 2019
@stsypanov stsypanov deleted the rt branch December 9, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement

3 participants

@stsypanov @jhoeller @spring-projects-issues