Skip to content

Conversation

@diguage
Copy link
Contributor

@diguage diguage commented Jan 12, 2019

I have some questions about AOP. So I research the source codes.

I want to debug the test source codes of AOP. I found the references of CountingBeforeAdvice was missed, and I found org.springframework.tests.aop.advice.CountingBeforeAdvice is in the repo.

Maybe the reference of CountingBeforeAdvice is incorrect. Please check it. Thanks a lot.

@diguage diguage force-pushed the bug-incorrect-references branch 3 times, most recently from 1dea734 to 92bb20c Compare January 12, 2019 15:12
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 24, 2019
@diguage
Copy link
Contributor Author

diguage commented Feb 5, 2019

@snicoll
What's wrong with the PR?

Happy Chinese New Year! 😆

@diguage diguage force-pushed the bug-incorrect-references branch from 92bb20c to 9b35e77 Compare December 11, 2019 06:57
@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Nov 10, 2021
@snicoll snicoll changed the title Maybe the reference of CountingBeforeAdvice is incorrect. References of CountingBeforeAdvice target its previous location Nov 28, 2021
@snicoll snicoll self-assigned this Nov 28, 2021
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 28, 2021
@snicoll snicoll added this to the 5.3.14 milestone Nov 28, 2021
snicoll pushed a commit that referenced this pull request Nov 28, 2021
snicoll added a commit that referenced this pull request Nov 28, 2021
@snicoll snicoll closed this in ef696c7 Nov 28, 2021
@snicoll
Copy link
Member

snicoll commented Nov 28, 2021

@diguage sorry it took so long to process it.

@diguage diguage deleted the bug-incorrect-references branch November 29, 2021 09:42
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug

4 participants