Provide a configuration property for the observation patterns of Spring Integration components #33099
+31 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Spring Integration can instrument its component with an `Observation` according to the `@EnableIntegrationManagement.observationPatterns` value * Expose `spring.integration.management.observation-patterns` configuration property * Propagate this property into an `@EnableIntegrationManagement` in the `IntegrationAutoConfiguration.IntegrationManagementConfiguration` * Verify that property has an effect via `IntegrationAutoConfigurationTests.integrationManagementInstrumentedWithObservation()`
spring-projects-issues added the status: waiting-for-triage 
philwebb added type: bug philwebb added the status: blocked 
| Considering this one a bug of omission, but we can't add it yet because we can't move to SNAPSHOTs before our next RC. |
| No. This is not a bug or omission. Thanks |
| By "bug of omission" I meant that it's a feature we should ideally have support for in the 3.0 release since the feature was added in Spring Integration 6. I guess you're right though, it's really an enhancement. I still think it might be worth adding to 3.0 if we can. It seems low risk. |
philwebb added type: enhancement | Sounds good, Phil! |
wilkinsona removed the status: blocked wilkinsona changed the title wilkinsona pushed a commit that referenced this pull request Nov 14, 2022
Spring Integration has introduced a new observationPatterns attribute on EnableIntegrationManagement. Spring Boot auto-configures EnableIntegrationManagement so this commit adds a property that allows users to configure the patterns without declaring the annotation themselves. See gh-33099
wilkinsona added a commit that referenced this pull request Nov 14, 2022
ndwlocatieservices added a commit to ndwnu/nls-accessibility-map that referenced this pull request Aug 19, 2024
…o v3 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [nu.ndw.nls.geometry:nls-geometry](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | major | `2.2.0` -> `3.0.0` | --- ### Release Notes <details> <summary>spring-projects/spring-boot (nu.ndw.nls.geometry:nls-geometry)</summary> ### [`v3.0.0`](https://github.com/spring-projects/spring-boot/releases/tag/v3.0.0) [Compare Source](spring-projects/spring-boot@v2.2.1.RELEASE...v3.0.0) See the [Release notes for 3.0](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Release-Notes) for upgrade instructions and details of new features. #### ⭐ New Features - Provide a configuration property for the observation patterns of Spring Integration components [#​33099](spring-projects/spring-boot#33099) #### 🐞 Bug Fixes - io.micrometer.tracing.Tracer on the classpath breaks AOT processing for tests [#​33298](spring-projects/spring-boot#33298) - Tracer library HTTP instrumentation is auto-configured unnecessarily [#​33287](spring-projects/spring-boot#33287) - Auto-configuration ignores user-provided ObservationConventions [#​33285](spring-projects/spring-boot#33285) - `ScheduledBeanLazyInitializationExcludeFilter` is auto-configured even when annotation-based scheduled has not been enabled [#​33284](spring-projects/spring-boot#33284) - SpringBootContextLoader prints banner twice when using a `@ContextHierarchy` [#​33263](spring-projects/spring-boot#33263) - Properties migrator causes an application to fail to start if it tries to map a property whose metadata data entry contains an invalid configuration property name [#​33250](spring-projects/spring-boot#33250) - Wavefront MeterRegistryCustomizer is not applying application tags from application.properties [#​33244](spring-projects/spring-boot#33244) - Actuator responses no longer format timestamps as ISO-8601 [#​33236](spring-projects/spring-boot#33236) - Configuration property is not bound in a native image when property has get, set, and is methods [#​33232](spring-projects/spring-boot#33232) - Configuration property binding does not deal with bridge methods [#​33212](spring-projects/spring-boot#33212) - Contribute missing resource hints for GraphQL schema files and GraphiQL HTML page [#​33208](spring-projects/spring-boot#33208) - Hints for ClientHttpRequestFactory should only be generated for matching methods [#​33203](spring-projects/spring-boot#33203) -...
ndwlocatieservices added a commit to ndwnu/nls-routing-map-matcher that referenced this pull request Aug 21, 2024
…o v3 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [nu.ndw.nls.geometry:nls-geometry](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | major | `2.1.4` -> `3.0.0` | --- ### Release Notes <details> <summary>spring-projects/spring-boot (nu.ndw.nls.geometry:nls-geometry)</summary> ### [`v3.0.0`](https://github.com/spring-projects/spring-boot/releases/tag/v3.0.0) [Compare Source](spring-projects/spring-boot@v2.2.1.RELEASE...v3.0.0) See the [Release notes for 3.0](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Release-Notes) for upgrade instructions and details of new features. #### ⭐ New Features - Provide a configuration property for the observation patterns of Spring Integration components [#​33099](spring-projects/spring-boot#33099) #### 🐞 Bug Fixes - io.micrometer.tracing.Tracer on the classpath breaks AOT processing for tests [#​33298](spring-projects/spring-boot#33298) - Tracer library HTTP instrumentation is auto-configured unnecessarily [#​33287](spring-projects/spring-boot#33287) - Auto-configuration ignores user-provided ObservationConventions [#​33285](spring-projects/spring-boot#33285) - `ScheduledBeanLazyInitializationExcludeFilter` is auto-configured even when annotation-based scheduled has not been enabled [#​33284](spring-projects/spring-boot#33284) - SpringBootContextLoader prints banner twice when using a `@ContextHierarchy` [#​33263](spring-projects/spring-boot#33263) - Properties migrator causes an application to fail to start if it tries to map a property whose metadata data entry contains an invalid configuration property name [#​33250](spring-projects/spring-boot#33250) - Wavefront MeterRegistryCustomizer is not applying application tags from application.properties [#​33244](spring-projects/spring-boot#33244) - Actuator responses no longer format timestamps as ISO-8601 [#​33236](spring-projects/spring-boot#33236) - Configuration property is not bound in a native image when property has get, set, and is methods [#​33232](spring-projects/spring-boot#33232) - Configuration property binding does not deal with bridge methods [#​33212](spring-projects/spring-boot#33212) - Contribute missing resource hints for GraphQL schema files and GraphiQL HTML page [#​33208](spring-projects/spring-boot#33208) - Hints for ClientHttpRequestFactory should only be generated for matching methods [#​33203](spring-projects/spring-boot#33203) -...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Spring Integration can instrument its component with an
Observationaccording to the@EnableIntegrationManagement.observationPatternsvaluespring.integration.management.observation-patternsconfiguration property@EnableIntegrationManagementin theIntegrationAutoConfiguration.IntegrationManagementConfigurationIntegrationAutoConfigurationTests.integrationManagementInstrumentedWithObservation()