Allow ParamSpecArgs to be unpacked #13459
Merged
+22 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sobolevn reviewed Aug 20, 2022
This comment has been minimized.
This comment has been minimized.
1 similar comment
| According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
sobolevn approved these changes Aug 20, 2022
| We would also need to test |
But not today :) |
JelleZijlstra approved these changes Aug 20, 2022
CheckmkCI pushed a commit to Checkmk/checkmk that referenced this pull request Sep 28, 2023
This should be possible since python/mypy#13459 (v0.990) Change-Id: I19475f6470228a1af6c30ac9889e0c8e371d9fb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
If
TypeVars with iterable bounds can be unpacked, so canParamSpecArgs! This PR is a small extension of #13425 that allows that to happen.Test Plan
I added a test that currently fails on
master, but passes with this patch applied.