chore: change globby library to glob #3438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sjarva commented Dec 15, 2022
| {cwd, ignore: ['**/node_modules/**']} | ||
| ).then((pJsons = []) => { | ||
| return pJsons.map((pJson) => require(Path.join(cwd, pJson))); | ||
| |
Contributor Author
There was a problem hiding this comment.
This is the part that needed some more modification - glob does not accept an array of strings, I decided to loop over the workspaces array. The flapMap is needed because glob.sync returns an array.
Member
There was a problem hiding this comment.
Tbh I rely on the tests here. If all tests still pass we should be able to expect we're good.
escapedcat approved these changes Dec 15, 2022
Member
escapedcat left a comment
escapedcat left a comment There was a problem hiding this comment.
Awesome @sjarva , thanks a lot!
| {cwd, ignore: ['**/node_modules/**']} | ||
| ).then((pJsons = []) => { | ||
| return pJsons.map((pJson) => require(Path.join(cwd, pJson))); | ||
| |
Member
There was a problem hiding this comment.
Tbh I rely on the tests here. If all tests still pass we should be able to expect we're good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
globas a dependency in the packages that usedglobbyglobbyas a dependencyglobbywith (sync) function fromglobglobbyaccepted an array of string as param, butglobaccepts only one string as paramMotivation and Context
Closes #2370
How Has This Been Tested?
I ran all of the tests with the
yarn testcommand. I'm not sure does this change needs new tests, but if so, I'm happy to add them.Types of changes
Checklist: