Add support for ByRole with name #1127
Merged
+112 −15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mdjastrzebski requested changes Sep 19, 2022
Member
mdjastrzebski left a comment
mdjastrzebski left a comment There was a problem hiding this comment.
Awesome work @AugustinLF!
The code is indeed much simpler after @MattAgn's #977.
I've added some minor suggests and tweaks to address before we merge this.
…ildren matching is supported
AugustinLF force-pushed the feat/by-role-with-name branch from 67b14da to 188a285 Compare mdjastrzebski requested changes Sep 22, 2022
Member
mdjastrzebski left a comment
mdjastrzebski left a comment There was a problem hiding this comment.
Requested one small minor readability change.
Collaborator Author
| @mdjastrzebski we should be good! |
mdjastrzebski approved these changes Sep 22, 2022
Member
There was a problem hiding this comment.
Great job @AugustinLF 🚀 Also big thank you 🙏🏻 to @kiranjd for submitting the initial implementation of this PR as #875.
Member
| 🎉 This PR is included in version 11.2.0 🎉 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Folllow up of #875. I started from scratch given the amount of conflicts.
Closes #827
If merged as is, don't forget to mention @kiranjd as part of the release.
Kudo to @MattAgn's work in #977 which made that a breeze. Look at the diff between this PR and the previously opened one, the code reorg was def the right call.