Support pdf files in file viewer #259

mmarif · 2020-01-29T10:08:27Z

mmarif commented

2020-01-29 10:08:27 +00:00

Will close #181

👀 1 🎉 1

mmarif added this to the 2.4.0 milestone 2020-01-29 10:08:27 +00:00

mmarif added the Feature label 2020-01-29 10:08:27 +00:00

mmarif self-assigned this 2020-01-29 10:08:27 +00:00

mmarif added the LGTM-need label 2020-01-29 14:14:24 +00:00

6543 commented

2020-01-30 08:24:10 +00:00

@mmarif I added a commit and this should be good for now (the issue with hiding pdf stuff sometimes)

I also tested the parametrs but as it is now it is the best in my opinion :)

@mmarif I added a commit and this should be good for now (the issue with hiding pdf stuff sometimes) I also tested the parametrs but as it is now it is the best in my opinion :)

6543 approved these changes 2020-01-30 08:24:50 +00:00

Dismissed

6543 left a comment

🚀

:rocket:

6543 added LGTM-done and removed LGTM-need labels 2020-01-30 08:24:59 +00:00

mmarif commented

2020-01-30 09:29:12 +00:00

@6543 should be ok then. Bdw the last line in your commit is required?

Also I am not getting emails from gitea anymore, is it the same for you?

@6543 should be ok then. Bdw the last line in your commit is required? Also I am not getting emails from gitea anymore, is it the same for you?

6543 commented

2020-01-30 09:32:18 +00:00

@mmarif you are right! about the mails I'll report

and about the EOL formation I'll add a .gitattribute witch should take care of it
(windows<->unix eol) but I think each file should end with a EOL (IDEs normlay add it to the sourcecode)

@mmarif you are right! about the mails I'll report and about the EOL formation I'll add a `.gitattribute` witch should take care of it (windows<->unix eol) but I think each file should end with a EOL (IDEs normlay add it to the sourcecode)

mmarif referenced this issue from a commit

2020-01-30 18:00:34 +00:00

Support pdf files in file viewer (#259) auto convert EOL this fix it for me fix layout implement support for pdf files in file viewer Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/259 Reviewed-by: 6543 <6543@noreply.gitea.io>

mmarif closed this pull request

2020-01-30 18:00:34 +00:00

mmarif deleted branch 181-pdf-support

2020-01-30 18:00:59 +00:00

mmarif referenced this issue from a commit

2020-02-24 18:50:55 +00:00

This repo is archived. You cannot comment on pull requests.

2 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#259