gitea/helm-gitea
Fork 168
Code Issues 56 Pull Requests 11 Actions Releases 103 Activity

fix: add srCheckPassword param to support new postgresql-ha stream replication check requirements #894

Merged
pat-s merged 2 commits from jadedeane/helm-gitea:main into main 2025-06-27 13:32:42 +00:00
Conversation 1 Commits 2 Files Changed 3 +11
jadedeane commented 2025-06-26 19:18:01 +00:00
Contributor
Copy Link

Add new 'srCheckPassword' postgresql-ha value to support new postgresql-ha stream replication check requirements

Per Bitnami's documentation, a new 'sr_check_user' now exists for the purpose of pgpool preforming stream replication checking.

Benefits

This change allows customizing that role's password by overriding Bitnami's chart value.

Possible drawbacks

None that I'm aware of.

Applicable issues

Additional information

Per #888, the Bitnami PR where customizable stream reapplication check credentials were introduced is https://github.com/bitnami/charts/pull/33552

Checklist

  • Parameters are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Helm templating unittests are added (required when changing anything in templates folder)
### Add new 'srCheckPassword' postgresql-ha value to support new postgresql-ha stream replication check requirements Per Bitnami's [documentation](https://github.com/bitnami/charts/tree/main/bitnami/postgresql-ha#to-1600), a new 'sr_check_user' now exists for the purpose of pgpool preforming stream replication checking. ### Benefits This change allows customizing that role's password by overriding Bitnami's chart value. ### Possible drawbacks None that I'm aware of. ### Applicable issues - Fixes #888 ### Additional information Per #888, the Bitnami PR where customizable stream reapplication check credentials were introduced is https://github.com/bitnami/charts/pull/33552 ### Checklist <!-- [Place an '[X]' (no spaces) in all applicable fields. Please remove unrelated fields.] --> - [x] Parameters are documented in the `values.yaml` and added to the `README.md` using [readme-generator-for-helm](https://github.com/bitnami-labs/readme-generator-for-helm) - [x] Helm templating unittests are added (required when changing anything in `templates` folder)
jadedeane added 2 commits 2025-06-26 19:18:01 +00:00
feat: add missing 'postgresql-ha.pgpool.srCheckPassword' to values, provide documentation and unit test update 9432999dcc
fix: incorrect secret name in unit test
Some checks failed
check-and-test / check-and-test (pull_request) Successful in 39s
Details
commitlint / check-and-test (pull_request) Has been cancelled
Details
8f88e17a57
jadedeane requested review from pat-s 2025-06-26 19:30:04 +00:00
pat-s approved these changes 2025-06-27 13:31:51 +00:00
pat-s left a comment
Collaborator
Copy Link

LGTM, thanks!

LGTM, thanks!
❤️ 1
pat-s changed title from feat: add 'srCheckPassword' to support new postgresql-ha stream replication check requirements to feat: add `srCheckPassword` param to support new postgresql-ha stream replication check requirements 2025-06-27 13:32:14 +00:00
pat-s changed title from feat: add `srCheckPassword` param to support new postgresql-ha stream replication check requirements to fix: add `srCheckPassword` param to support new postgresql-ha stream replication check requirements 2025-06-27 13:32:29 +00:00
pat-s merged commit aa7ccb47ba into main 2025-06-27 13:32:42 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
pat-s
Labels
Clear labels
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
workaround
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
42wim 6543 a1012112796 Akkuman appleboy axifive betacat0 blumia bwko caicandong ChristopherHX DaanSelen davidsvantesson delvh denyskon fuxiaohei gary-kim garymoon giteabot guillep2k HesterG hiifong jaqra jolheiser jonasfranz jpraet kdumontnu kemzeb kerwin612 khmarbaise KN4CK3R kolaente lafriks lng2020 lotherk luhahn lunny mrsdizzie noerw pat-s puni9869 renovate-bot richmahn rossigee sapk screenshots sillyguodong silverwind smartclip_tim strk tboerger techknowlogick TheFox0x7 tobiasbp typeless volker.raschek wolfogre wxiaoguang yardenshoham yp05327 zeripath Zettat123
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gitea/helm-gitea#894
No description provided.
Delete Branch "jadedeane/helm-gitea:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?