gitea/helm-gitea
Fork 169
Code Issues 54 Pull Requests 13 Actions Releases 103 Activity

refactor!: remove actions related files #825

Merged
pat-s merged 4 commits from chore/remove-actions into main 2025-03-31 07:47:24 +00:00
Conversation 7 Commits 4 Files Changed 23 +10 -1176
pat-s commented 2025-03-06 21:37:05 +00:00
Collaborator
Copy Link

see #824

see #824
pat-s added 1 commit 2025-03-06 21:37:05 +00:00
chore: remove actions related files
Some checks failed
commitlint / check-and-test (pull_request) Successful in 5s
Details
check-and-test / check-and-test (pull_request) Failing after 15s
Details
779e9f28e8
pat-s requested review from justusbunsi 2025-03-06 21:37:05 +00:00
pat-s added 1 commit 2025-03-06 21:38:34 +00:00
chore: helpers
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 42s
Details
commitlint / check-and-test (pull_request) Successful in 7s
Details
26d4a53449
pat-s commented 2025-03-27 17:25:30 +00:00
Author
Collaborator
Copy Link

@justusbunsi Any comments? Otherwise I'll merge soon.

@justusbunsi Any comments? Otherwise I'll merge soon.
lunny reviewed 2025-03-27 18:03:42 +00:00
README.md Outdated
@@ -1069,44 +1068,6 @@ To comply with the Gitea helm chart definition of the digest parameter, a "custo
| `signing.privateKey` | Inline private gpg key for signed internal Git activity | `""` |
| `signing.existingSecret` | Use an existing secret to store the value of `signing.privateKey` | `""` |
### Gitea Actions
lunny commented 2025-03-27 18:03:42 +00:00
Owner
Copy Link

Can this content be copied to helm-actions before it’s removed?

Can this content be copied to helm-actions before it’s removed?
pat-s commented 2025-03-28 08:16:16 +00:00
Author
Collaborator
Copy Link

The README content is auto-generated and doesn't need to be copied. See Makefile.

The README content is auto-generated and doesn't need to be copied. See Makefile.
ChristopherHX commented 2025-03-28 11:13:01 +00:00
Member
Copy Link

I just tried to generate the readme, helm-actions Makefile has pnpm commands included. Now as it has no package.json make readme is broken as well.

I just tried to generate the readme, helm-actions Makefile has pnpm commands included. Now as it has no `package.json` `make readme` is broken as well.
👍 1
lunny marked this conversation as resolved
lunny approved these changes 2025-03-29 03:10:39 +00:00
lunny added the
kind
breaking
 label 2025-03-29 03:10:51 +00:00
justusbunsi requested changes 2025-03-30 13:38:00 +00:00
Dismissed
unittests/helm/config/actions-config.yaml Outdated
@@ -1,61 +0,0 @@
suite: config template | actions config
justusbunsi commented 2025-03-30 13:20:40 +00:00
Contributor
Copy Link

Let's keep this test file but trim it to our needs:

  • We should define a test case actions are enabled by default. This will catch future regressions on this regards
  • Replace test case actions can be enabled via inline config by actions can be disabled via inline config
  • Drop the other test cases
Let's keep this test file but trim it to our needs: - We should define a test case `actions are enabled by default`. This will catch future regressions on this regards - Replace test case `actions can be enabled via inline config` by `actions can be disabled via inline config` - Drop the other test cases
justusbunsi changed title from refactor: remove actions related files to refactor!: remove actions related files 2025-03-30 13:38:13 +00:00
justusbunsi added 1 commit 2025-03-30 14:01:33 +00:00
Merge branch 'main' into chore/remove-actions
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 48s
Details
b41ab3e4f1
pat-s requested review from justusbunsi 2025-03-30 14:01:34 +00:00
justusbunsi added 1 commit 2025-03-30 14:08:00 +00:00
Restore adjusted actions config related tests
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 43s
Details
7d67a233e6 
Signed-off-by: justusbunsi <sk.bunsenbrenner@gmail.com>
justusbunsi commented 2025-03-30 14:09:05 +00:00
Contributor
Copy Link

@pat-s I took the liberty of proposing what I suggested. Let me know if this works for you.

@pat-s I took the liberty of proposing what I suggested. Let me know if this works for you.
justusbunsi approved these changes 2025-03-30 14:09:35 +00:00
justusbunsi left a comment
Contributor
Copy Link

🧙

🧙
pat-s commented 2025-03-31 07:47:08 +00:00
Author
Collaborator
Copy Link

Good catch (as always ;)).

Good catch (as always ;)).
pat-s merged commit 6c5b42c482 into main 2025-03-31 07:47:24 +00:00
pat-s deleted branch chore/remove-actions 2025-03-31 07:47:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
lunny
justusbunsi
Labels
Clear labels
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
workaround
No Label
kind
breaking
Milestone
No items
No Milestone
Assignees
Clear assignees
42wim 6543 a1012112796 Akkuman appleboy axifive betacat0 blumia bwko caicandong ChristopherHX DaanSelen davidsvantesson delvh denyskon fuxiaohei gary-kim garymoon giteabot guillep2k HesterG hiifong jaqra jolheiser jonasfranz jpraet kdumontnu kemzeb kerwin612 khmarbaise KN4CK3R kolaente lafriks lng2020 lotherk luhahn lunny mrsdizzie noerw pat-s puni9869 renovate-bot richmahn rossigee sapk screenshots sillyguodong silverwind smartclip_tim strk tboerger techknowlogick TheFox0x7 tobiasbp typeless volker.raschek wolfogre wxiaoguang yardenshoham yp05327 zeripath Zettat123
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gitea/helm-gitea#825
No description provided.
Delete Branch "chore/remove-actions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?