gitea/helm-gitea
Fork 169
Code Issues 53 Pull Requests 11 Actions Releases 103 Activity

Allow override kubernetes probes #117

Merged
lafriks merged 2 commits from viceice/gitea-helm-chart:feat/custom-probes into master 2021-03-01 14:46:06 +00:00
Conversation 7 Commits 2 Files Changed 3 +107 -9
viceice commented 2021-02-22 10:17:10 +00:00
Contributor
Copy Link
  • Allow overriding liveness and readiness probe
  • Add optional startup probe

closes #118

- Allow overriding liveness and readiness probe - Add optional startup probe closes #118
viceice commented 2021-02-22 10:24:30 +00:00
Author
Contributor
Copy Link

Tested with helm template . to verify valid yaml. Should generate the probes as before this pr by default.

Tested with `helm template .` to verify valid yaml. Should generate the probes as before this pr by default.
luhahn commented 2021-02-23 15:53:17 +00:00
Member
Copy Link

thanks for the PR will test this tomorrow!

thanks for the PR will test this tomorrow!
luhahn approved these changes 2021-02-24 08:23:23 +00:00
Dismissed
luhahn left a comment
Member
Copy Link

Tested on my cluster with different values. Looks good to me!

Thanks for your effort :)

Tested on my cluster with different values. Looks good to me! Thanks for your effort :)
viceice commented 2021-02-24 08:28:39 +00:00
Author
Contributor
Copy Link

No problem, like to see it merged soon 😉

No problem, like to see it merged soon :wink:
lafriks commented 2021-03-01 12:18:50 +00:00
Owner
Copy Link

please resolve conflicts

please resolve conflicts
viceice commented 2021-03-01 12:33:16 +00:00
Author
Contributor
Copy Link

done ?

done ?
viceice force-pushed feat/custom-probes from 40fe1ae86a to dd88ef2125 2021-03-01 12:33:59 +00:00 Compare
lafriks approved these changes 2021-03-01 14:45:54 +00:00
Dismissed
lafriks merged commit 551f4e312e into master 2021-03-01 14:46:06 +00:00
lafriks added the
kind
enhancement
 label 2021-03-01 14:46:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
workaround
No Label
kind
enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
42wim 6543 a1012112796 Akkuman appleboy axifive betacat0 blumia bwko caicandong ChristopherHX DaanSelen davidsvantesson delvh denyskon fuxiaohei gary-kim garymoon giteabot guillep2k HesterG hiifong jaqra jolheiser jonasfranz jpraet kdumontnu kemzeb kerwin612 khmarbaise KN4CK3R kolaente lafriks lng2020 lotherk luhahn lunny mrsdizzie noerw pat-s puni9869 renovate-bot richmahn rossigee sapk screenshots sillyguodong silverwind smartclip_tim strk tboerger techknowlogick TheFox0x7 tobiasbp typeless volker.raschek wolfogre wxiaoguang yardenshoham yp05327 zeripath Zettat123
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gitea/helm-gitea#117
No description provided.
Delete Branch "viceice/gitea-helm-chart:feat/custom-probes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?