gitea/helm-gitea
Fork 169
Code Issues 54 Pull Requests 11 Actions Releases 103 Activity

Fix LDAP Ppassword env variable #182

Merged
techknowlogick merged 1 commits from fix-ldap-password into master 2021-06-15 21:08:00 +00:00
Conversation 4 Commits 1 Files Changed 1 +1 -1
luhahn commented 2021-06-15 20:26:52 +00:00
Member
Copy Link

Fixes: #179

Fixes: #179
zeripath approved these changes 2021-06-15 20:28:52 +00:00
luhahn force-pushed fix-ldap-password from e2047afa44 to 5de9034e6d 2021-06-15 20:29:00 +00:00 Compare
techknowlogick approved these changes 2021-06-15 21:07:30 +00:00
techknowlogick merged commit e3b03cd61a into master 2021-06-15 21:08:00 +00:00
justusbunsi commented 2021-06-15 21:08:02 +00:00
Contributor
Copy Link

TBH, this seems to not fully fix the regression or at least not fully finalize this feature. Previous to that PR, the admin user was created by using the LDAP bind settings (if I'm getting this right). Now with the correct environment variable for the LDAP credentials no admin user will be created when using existingSecret for the admin account. This feature was introduced with c49dc047a4 as well, I assume that we should fix this, too. Right now the admin account is only created when using inline credentials in values.yaml (see c49dc047a4/templates/gitea/init.yaml (L43))

TBH, this seems to not fully fix the regression or at least not fully finalize this feature. Previous to that PR, the admin user was created by using the LDAP bind settings (if I'm getting this right). Now with the correct environment variable for the LDAP credentials no admin user will be created when using `existingSecret` for the admin account. This feature was introduced with c49dc047a498973920e6743fa6c330fd2f81dd47 as well, I assume that we should fix this, too. Right now the admin account is only created when using inline credentials in `values.yaml` (see https://gitea.com/gitea/helm-chart/src/commit/c49dc047a498973920e6743fa6c330fd2f81dd47/templates/gitea/init.yaml#L43)
justusbunsi commented 2021-06-15 21:08:23 +00:00
Contributor
Copy Link

Oh no... too late.

Oh no... too late.
justusbunsi added the
kind
bug
 label 2021-06-30 10:18:40 +00:00
justusbunsi added this to the Release 4.0.0 milestone 2021-06-30 10:18:46 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
zeripath
techknowlogick
Labels
Clear labels
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
workaround
No Label
kind
bug
Milestone
No items
No Milestone Release 4.0.0
Assignees
Clear assignees
42wim 6543 a1012112796 Akkuman appleboy axifive betacat0 blumia bwko caicandong ChristopherHX DaanSelen davidsvantesson delvh denyskon fuxiaohei gary-kim garymoon giteabot guillep2k HesterG hiifong jaqra jolheiser jonasfranz jpraet kdumontnu kemzeb kerwin612 khmarbaise KN4CK3R kolaente lafriks lng2020 lotherk luhahn lunny mrsdizzie noerw pat-s puni9869 renovate-bot richmahn rossigee sapk screenshots sillyguodong silverwind smartclip_tim strk tboerger techknowlogick TheFox0x7 tobiasbp typeless volker.raschek wolfogre wxiaoguang yardenshoham yp05327 zeripath Zettat123
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gitea/helm-gitea#182
No description provided.
Delete Branch "fix-ldap-password"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?