Error in statefulset (for any who non use ldap) #179

New Issue

visteras · 2021-06-13T09:53:20Z

2021-06-13 09:53:20 +00:00

....HOW??
I just update repo and see error:

Error: UPGRADE FAILED: cannot patch "gitea" with kind StatefulSet: The order in patch list: [map[name:GITEA_TEMP value:/tmp/gitea] map[name:GITEA_LDAP_BIND_DN value:] map[name:GITEA_ADMIN_PASSWORD value:] map[name:GITEA_ADMIN_PASSWORD value:false] map[name:GITEA_ADMIN_USERNAME value:false]] doesn't match $setElementOrder list: [map[name:GITEA_APP_INI] map[name:GITEA_CUSTOM] map[name:GITEA_WORK_DIR] map[name:GITEA_TEMP] map[name:GITEA_LDAP_BIND_DN] map[name:GITEA_ADMIN_PASSWORD] map[name:GITEA_ADMIN_USERNAME] map[name:GITEA_ADMIN _PASSWORD]]

This have'not normal testing... why this commit in production?
c49dc047a4

And after update i see duplicate GITEA_ADMIN_PASSWORD in env:
c49dc047a4/templates/gitea/statefulset.yaml (L67)

....HOW?? I just update repo and see error: ``` Error: UPGRADE FAILED: cannot patch "gitea" with kind StatefulSet: The order in patch list: [map[name:GITEA_TEMP value:/tmp/gitea] map[name:GITEA_LDAP_BIND_DN value:] map[name:GITEA_ADMIN_PASSWORD value:] map[name:GITEA_ADMIN_PASSWORD value:false] map[name:GITEA_ADMIN_USERNAME value:false]] doesn't match $setElementOrder list: [map[name:GITEA_APP_INI] map[name:GITEA_CUSTOM] map[name:GITEA_WORK_DIR] map[name:GITEA_TEMP] map[name:GITEA_LDAP_BIND_DN] map[name:GITEA_ADMIN_PASSWORD] map[name:GITEA_ADMIN_USERNAME] map[name:GITEA_ADMIN _PASSWORD]] ``` This have'not normal testing... why this commit in production? https://gitea.com/gitea/helm-chart/commit/c49dc047a498973920e6743fa6c330fd2f81dd47 And after update i see duplicate GITEA_ADMIN_PASSWORD in env: https://gitea.com/gitea/helm-chart/src/commit/c49dc047a498973920e6743fa6c330fd2f81dd47/templates/gitea/statefulset.yaml#L67

context commented

2021-06-15 05:04:57 +00:00

Correct. The template is wrong. This needs to be setting GITEA_LDAP_PASSWORD

Correct. The template is wrong. This needs to be setting `GITEA_LDAP_PASSWORD`

viceice commented

2021-06-15 17:04:32 +00:00

I'm seeing this too. Why again a breaking change in a bugfix release? ?

╷ │ Error: cannot patch "gitea" with kind StatefulSet: The order in patch list: │ [map[name:GITEA_TEMP value:/tmp/gitea] map[name:GITEA_LDAP_BIND_DN value:] map[name:GITEA_ADMIN_PASSWORD value:] map[name:GITEA_ADMIN_PASSWORD value:XXXXXXXXXXX] map[name:GITEA_ADMIN_USERNAME value:XXXXXXX]] │ doesn't match $setElementOrder list: │ [map[name:GITEA_APP_INI] map[name:GITEA_CUSTOM] map[name:GITEA_WORK_DIR] map[name:GITEA_TEMP] map[name:GITEA_LDAP_BIND_DN] map[name:GITEA_ADMIN_PASSWORD] map[name:GITEA_ADMIN_USERNAME] map[name:GITEA_ADMIN_PASSWORD]] │ │ │ with module.prod.module.gitea.helm_release.gitea, │ on modules/gitea/gitea.tf line 1, in resource "helm_release" "gitea": │ 1: resource "helm_release" "gitea" { │ ╵ Error: Process completed with exit code 1.

I'm seeing this too. Why again a breaking change in a bugfix release? ? ``` ╷ │ Error: cannot patch "gitea" with kind StatefulSet: The order in patch list: │ [map[name:GITEA_TEMP value:/tmp/gitea] map[name:GITEA_LDAP_BIND_DN value:] map[name:GITEA_ADMIN_PASSWORD value:] map[name:GITEA_ADMIN_PASSWORD value:XXXXXXXXXXX] map[name:GITEA_ADMIN_USERNAME value:XXXXXXX]] │ doesn't match $setElementOrder list: │ [map[name:GITEA_APP_INI] map[name:GITEA_CUSTOM] map[name:GITEA_WORK_DIR] map[name:GITEA_TEMP] map[name:GITEA_LDAP_BIND_DN] map[name:GITEA_ADMIN_PASSWORD] map[name:GITEA_ADMIN_USERNAME] map[name:GITEA_ADMIN_PASSWORD]] │ │ │ with module.prod.module.gitea.helm_release.gitea, │ on modules/gitea/gitea.tf line 1, in resource "helm_release" "gitea": │ 1: resource "helm_release" "gitea" { │ ╵ Error: Process completed with exit code 1. ```

viceice referenced this issue

2021-06-15 17:05:32 +00:00

Allow existing secrets for passwords #170

viceice commented

2021-06-15 17:06:29 +00:00

This is caused by a breaking change in #170 with was released as v3.1.4 ?

luhahn commented

2021-06-15 20:14:06 +00:00

Hi you guys, and sorry for the trouble. I'm pretty swamped with work and I missed this error. Till now the chart was mainly maintained by myself. Luckily I just got help by two additional maintainers fokusing on the chart.

luhahn referenced a pull request that will close this issue

2021-06-15 20:26:52 +00:00

Fix LDAP Ppassword env variable #182

techknowlogick closed this issue

2021-06-15 21:08:00 +00:00

techknowlogick referenced this issue from a commit

2021-06-15 21:08:00 +00:00

Fix LDAP Ppassword env variable (#182)

justusbunsi added the

kind

bug

label 2021-06-30 10:19:59 +00:00