gitea/helm-gitea
Fork 169
Code Issues 54 Pull Requests 11 Actions 2 Releases 103 Activity

Fix wrong reference to existingKey (#415)
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse Source 
### Description of the change Fix a wrong reference to `signing.existingKey`, `signing.existingSecret` was what was meant and what is used in the chart. ### Benefits Less confusion when trying to use the Helm chart. ### Possible drawbacks Evangelists of `existingKey` storming the barricades even though `existingKey` is long dead. ### Applicable issues None, nobody noticed enough to care, apparently. Co-authored-by: Tobias Wolter <towo@towo.eu> Reviewed-on: gitea/helm-chart#415 Reviewed-by: pat-s <pat-s@noreply.gitea.io> Reviewed-by: justusbunsi <justusbunsi@noreply.gitea.io> Co-authored-by: towo <towo@noreply.gitea.io> Co-committed-by: towo <towo@noreply.gitea.io>
This commit was merged in pull request #415.
This commit is contained in:
towo
2023-03-21 14:16:41 +08:00
committed by justusbunsi
parent 9a6cb4d357
commit 4869aed6ad
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@@ -543,7 +543,7 @@ signing:
Regardless of the used container image the `signing` object allows to specify a
private gpg key. Either using the `signing.privateKey` to define the key inline,
or refer to an existing secret containing the key data by using `signing.existingKey`.
or refer to an existing secret containing the key data by using `signing.existingSecret`.
```yaml
apiVersion: v1

2
templates/gitea/gpg-secret.yaml
View File

@@ -1,6 +1,6 @@
{{- if .Values.signing.enabled -}}
{{- if and (empty .Values.signing.privateKey) (empty .Values.signing.existingSecret) -}}
{{- fail "Either specify `signing.privateKey` or `signing.existingKey`" -}}
{{- fail "Either specify `signing.privateKey` or `signing.existingSecret`" -}}
{{- end }}
{{- if and (not (empty .Values.signing.privateKey)) (empty .Values.signing.existingSecret) -}}
apiVersion: v1

2
unittests/gpg-secret/signing-enabled.yaml
View File

@@ -11,7 +11,7 @@ tests:
enabled: true
asserts:
- failedTemplate:
errorMessage: Either specify `signing.privateKey` or `signing.existingKey`
errorMessage: Either specify `signing.privateKey` or `signing.existingSecret`
- it: skips rendering using external secret reference
set:
signing: