gitea/go-sdk
Fork 95
Code Issues 25 Pull Requests 5 Actions Releases 23 Activity

Add response to ReadRepoNotifications #590

Merged
6543 merged 11 commits from Gusted/go-sdk:notification-api-response into master 2022-05-15 15:47:38 +00:00
Conversation 9 Commits 11 Files Changed 3 +54 -19
Gusted commented 2022-05-03 00:56:45 +00:00
Contributor
Copy Link
- This is a breaking change. - Return the relevant notifications when the Gitea server is 1.16.0 or higher. - Ref: https://github.com/go-gitea/gitea/pull/17064 - Resolves #543
Gusted added 1 commit 2022-05-03 00:56:46 +00:00
Add response to ReadRepoNotifications
Some checks failed
continuous-integration/drone/pr Build is failing
Details
33e75639b6 
- This is a breaking change. - Return the relevant notifications when the Gitea server is 1.16.0 or higher. - Ref: https://github.com/go-gitea/gitea/pull/17064 - Resolves #543
Gusted added 1 commit 2022-05-03 01:26:17 +00:00
Implement other part
Some checks failed
continuous-integration/drone/pr Build is failing
Details
5c31ce14f0
Gusted added 1 commit 2022-05-03 01:27:33 +00:00
Fix CI
Some checks failed
continuous-integration/drone/pr Build is failing
Details
4cfdcef551
Gusted added 1 commit 2022-05-03 01:28:36 +00:00
Correct amount
Some checks failed
continuous-integration/drone/pr Build is failing
Details
d2279674fe
Gusted commented 2022-05-03 01:28:51 +00:00
Author
Contributor
Copy Link

Tests fails due to: https://github.com/go-gitea/gitea/pull/19589

Tests fails due to: https://github.com/go-gitea/gitea/pull/19589
Gusted added 1 commit 2022-05-03 01:29:48 +00:00
Fix revive lint
Some checks failed
continuous-integration/drone/pr Build is failing
Details
4bf2701e99
Gusted added 1 commit 2022-05-03 01:33:04 +00:00
Poor CI
Some checks failed
continuous-integration/drone/pr Build is failing
Details
e614684d4e
Gusted added 1 commit 2022-05-03 14:18:33 +00:00
Empty commit
Some checks failed
continuous-integration/drone/pr Build is failing
Details
1b2d1a157d
Gusted added 1 commit 2022-05-03 14:20:37 +00:00
Another empty commit
All checks were successful
continuous-integration/drone/pr Build is passing
Details
3d68477257
Gusted commented 2022-05-03 14:22:49 +00:00
Author
Contributor
Copy Link

https://drone.gitea.com/gitea/go-sdk/525/1/2 Docker is stuck?

https://drone.gitea.com/gitea/go-sdk/525/1/2 Docker is stuck?
6543 added the kind/breaking label 2022-05-03 17:44:23 +00:00
6543 added this to the v0.16.0 milestone 2022-05-03 17:44:28 +00:00
6543 commented 2022-05-03 17:45:09 +00:00
Owner
Copy Link

since it's a breaking change, can you add a note into https://gitea.com/gitea/go-sdk/src/branch/master/docs/migrate-v0.15-to-v0.16.md ?

since it's a breaking change, can you add a note into https://gitea.com/gitea/go-sdk/src/branch/master/docs/migrate-v0.15-to-v0.16.md ?
👍 1
6543 added the kind/enhancement label 2022-05-03 17:45:18 +00:00
lunny commented 2022-05-04 02:34:08 +00:00
Owner
Copy Link

I have restarted CI. Look like it will fail randomly.

I have restarted CI. Look like it will fail randomly.
Gusted added 1 commit 2022-05-12 21:24:32 +00:00
Add migration note
Some checks failed
continuous-integration/drone/pr Build is failing
Details
b3a248dde1
Gusted commented 2022-05-12 21:24:44 +00:00
Author
Contributor
Copy Link

Added the migration note b3a248dde1

Added the migration note https://gitea.com/gitea/go-sdk/commit/b3a248dde18afbe6a746ef9676b2aeef4bd9e7c3
❤️ 1
6543 reviewed 2022-05-14 15:23:01 +00:00
gitea/notifications.go Outdated
@@ -161,3 +161,3 @@
// ReadNotification mark notification thread as read by ID
// It optionally takes a second argument if status has to be set other than 'read'
func (c *Client) ReadNotification(id int64, status ...NotifyStatus) (*Response, error) {
// The relevant notification will be returned as the first parameter when the Gitea server is 1.16.0 or higher.
6543 commented 2022-05-14 15:23:01 +00:00
Owner
Copy Link
-// The relevant notification will be returned as the first parameter when the Gitea server is 1.16.0 or higher. +// The relevant notification will be returned as the first parameter when the Gitea server is 1.16.0 or higher.
```diff -// The relevant notification will be returned as the first parameter when the Gitea server is 1.16.0 or higher. +// The relevant notification will be returned as the first parameter when the Gitea server is 1.16.0 or higher. ```
Gusted marked this conversation as resolved
Gusted added 1 commit 2022-05-14 20:22:28 +00:00
Fix comment
Some checks failed
continuous-integration/drone/pr Build is failing
Details
fcfee1d882 
Co-Authored-By: 6543 <6543@obermui.de>
6543 approved these changes 2022-05-14 22:02:55 +00:00
6543 left a comment
Owner
Copy Link

CI fail is unrelated ...

CI fail is unrelated ...
Gusted added 1 commit 2022-05-15 11:20:20 +00:00
Merge branch 'master' into notification-api-response
All checks were successful
continuous-integration/drone/pr Build is passing
Details
849eac00d2
6543 approved these changes 2022-05-15 13:05:48 +00:00
lunny approved these changes 2022-05-15 14:24:03 +00:00
6543 merged commit 99a9de3172 into master 2022-05-15 15:47:38 +00:00
Gusted deleted branch notification-api-response 2022-05-15 16:33:35 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
6543
lunny
Labels
Clear labels
has/backport
has/pull
in progress
invalid
kind/breaking
kind/bug
kind/build
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/refactor
kind/security
kind/testing
kind/translation
kind/ui
need/backport
priority/critical
priority/low
priority/maybe
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
No Label kind/breaking kind/enhancement
Milestone
No items
No Milestone v0.16.0
Assignees
Clear assignees
42wim 6543 a1012112796 Akkuman appleboy axifive betacat0 blumia bwko caicandong ChristopherHX davidsvantesson delvh denyskon fuxiaohei gary-kim garymoon giteabot guillep2k HesterG hiifong jaqra jolheiser jonasfranz jpraet kdumontnu kemzeb kerwin612 khmarbaise KN4CK3R kolaente lafriks lng2020 luhahn lunny mrsdizzie noerw puni9869 renovate-bot richmahn sapk screenshots sillyguodong silverwind smartclip_tim strk tboerger techknowlogick TheFox0x7 tobiasbp typeless volker.raschek wolfogre wxiaoguang yardenshoham yp05327 zeripath Zettat123
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gitea/go-sdk#590
No description provided.
Delete Branch "Gusted/go-sdk:notification-api-response"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?