summaryrefslogtreecommitdiff
path: root/bin
diff options
authorPierre Equoy <pierre.equoy@canonical.com>2019-06-25 15:26:13 +0800
committerPierre Equoy <pierre.equoy@canonical.com>2019-06-25 15:26:13 +0800
commitf475fdd5536c3230ceb72c29e4e998d9b1989a65 (patch)
treeee581b4cc0d605473e3abd9751b69e202c4bc9c0 /bin
parent7dca4e768f12bcfdbe27310de5ecb277c27817a0 (diff)
bin:pm_test: use the proper fwts.log file to compute sleep/resume times
pm_test relies on fwts_test.py from checkbox_support. However, fwts_test.py --log argument takes a filename without and appends `.log` to it. When calling it from pm_test with argument `--log={}/fwts.log`, we are in fact working on file `fwts.log.log` instead of `fwts.log`, so the log file used for later computation is erroneous (it doesn't contain the "Iteration n" markers needed to find the average sleep/resume times), which leads to wrong results and ultimately a set of jobs (power-management/suspend-*-cycles-time-check*) that always fail. LP: #1834127
Diffstat (limited to 'bin')
-rwxr-xr-xbin/pm_test2
1 files changed, 1 insertions, 1 deletions
diff --git a/bin/pm_test b/bin/pm_test
index dd9e1a0a..f4558583 100755
--- a/bin/pm_test
+++ b/bin/pm_test
@@ -188,7 +188,7 @@ class PowerManagementOperation():
command_tpl = '-s s3 --s3-device-check ' \
'--s3-sleep-delay=30 --s3-multiple={}'
if self.args.log_dir:
- command_tpl = '--log={}/fwts.log '.format(
+ command_tpl = '--log={}/fwts '.format(
self.args.log_dir) + command_tpl
command_tpl = '{} ' + command_tpl
else: