ethernet: static config job networkd/nm support

Convert the old check-{if}-static script to python. Add support for doing the same type of test when the interface is managed by networkd. Allow check the address that was assigned through a config variable. 

2 files changed, 95 insertions, 28 deletions

diff --git a/bin/check_static b/bin/check_static
deleted file mode 100755
index dc649d5c..00000000
--- a/bin/check_static
+++ /dev/null
@@ -1,28 +0,0 @@
-#!/bin/bash
-
-IFACE="$1"
-
-if [ "$IFACE" = "" ]; then
- echo "No interface specified"
- exit 1
-fi
-
-CARRIER=$(nmcli -t --fields WIRED-PROPERTIES.CARRIER d show $IFACE | cut -d ":" -f 2)
-if [ "$CARRIER" = "off" ]; then
- echo "No cable present"
- exit 1
-fi
-
-CONN_NAME=$(nmcli -t --fields GENERAL.CONNECTION d show $IFACE | cut -d ":" -f 2)
-if [ "$CONN_NAME" = "--" ]; then
- echo "No connection active on $IFACE"
- exit 1
-fi
-echo "Connection active on $IFACE is $CONN_NAME"
-
-CONN_METHOD=$(nmcli -t --fields ipv4.method c show "$CONN_NAME" | cut -d ":" -f 2)
-if [ "$CONN_METHOD" = "auto" ]; then
- echo "FAIL: $CONN_METHOD"
- exit 1
-fi
-echo "PASS: $CONN_METHOD"
diff --git a/bin/check_static.py b/bin/check_static.py
new file mode 100755
index 00000000..922d98f2
--- /dev/null
+++ b/bin/check_static.py
@@ -0,0 +1,95 @@
+#!/usr/bin/env python3
+# Copyright 2020 Canonical Ltd.
+# All rights reserved.
+#
+# Written by:
+# Jonathan Cave <jonathan.cave@canonical.com>
+
+import configparser
+import os
+import subprocess as sp
+import sys
+
+
+def check_networkmanager(interface, expected_address):
+ def nmcli_field(cmd):
+ val = sp.check_output(cmd).decode(
+ sys.stdout.encoding).strip().split(':')[1]
+ return val
+
+ carrier = nmcli_field(['nmcli', '-t', '--fields',
+ 'WIRED-PROPERTIES.CARRIER', 'd', 'show', interface])
+ if carrier == "off":
+ raise SystemExit("ERROR: No cable present")
+
+ conn_name = nmcli_field(['nmcli', '-t', '--fields', 'GENERAL.CONNECTION',
+ 'd', 'show', interface])
+ if conn_name == "--":
+ raise SystemExit("ERROR: No connection active on {}".format(interface))
+ print("Connection active on {} is {}".format(interface, conn_name))
+
+ conn_method = nmcli_field(
+ ['nmcli', '-t', '--fields', 'ipv4.method', 'c', 'show', conn_name])
+ if conn_method == "auto":
+ raise SystemExit("FAIL: connection method {}".format(conn_method))
+
+ address = nmcli_field(['nmcli', '-t', '--fields', 'IP4.ADDRESS', 'c',
+ 'show', conn_name])
+ print('Found static address: {}'.format(address))
+ if expected_address:
+ if expected_address != address:
+ raise SystemExit('FAIL: address doesn\'t match')
+
+
+def check_networkd(interface, expected_address):
+ config_f = '/run/systemd/network/10-netplan-{}.network'.format(interface)
+ if not os.path.exists(config_f):
+ raise SystemExit(
+ 'ERROR: expected config file does not exist {}'.format(config_f))
+
+ parser = configparser.ConfigParser()
+ parser.optionxform = str
+ parser.read(config_f)
+
+ if 'Network' not in parser.sections():
+ raise SystemExit('ERROR: no section "Network" found in config file ')
+
+ if 'DHCP' in parser['Network']:
+ if parser['Network']['DHCP'] in ('true', 'ipv4', 'ipv6'):
+ raise SystemExit('FAIL: interface configured for DHCP')
+
+ if 'Address' in parser['Network']:
+ print('Found static address: {}'.format(parser['Network']['Address']))
+ if expected_address:
+ if expected_address != parser['Network']['Address']:
+ raise SystemExit('FAIL: address doesn\'t match')
+
+
+def main():
+ if len(sys.argv) != 3:
+ raise SystemExit('USAGE: check_static.py [manager] [interface]')
+ manager = sys.argv[1]
+ interface = sys.argv[2]
+
+ if not os.path.exists('/sys/class/net/{}'.format(interface)):
+ raise SystemExit('ERROR: {} doesn\'t exist'.format(interface))
+
+ configuration_key = 'STATIC_IP_{}'.format(interface.upper())
+ expected_address = os.environ.get(configuration_key)
+ if expected_address:
+ print('Testing for expected address: {}={}\n'.format(
+ configuration_key, expected_address))
+ else:
+ print('No expected address specified, testing for non-DHCP only')
+ print('Set key {} for address check\n'.format(configuration_key))
+
+ if manager == 'nm':
+ check_networkmanager(interface, expected_address)
+ elif manager == 'networkd':
+ check_networkd(interface, expected_address)
+
+ print("PASS")
+
+
+if __name__ == '__main__':
+ main()